-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.46] shared abseil on windows + test overhaul #239
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Yay, passing windows builds, including a full-fledged configure+build test for using the produced artefacts through cmake. 🥳 Unix still needs conda-forge/libprotobuf-feedstock#127 / conda-forge/libprotobuf-feedstock#128 (if we want to also switch on the cmake example). @conda-forge/grpc-cpp @hmaarrfk PTAL PS. The commits are most likely easier to review individually. |
I don't think I'll be of much use to review and as such, i would like to take a back seat on this. I think you have many capable users of the library that might be able to give you feedback better than i can. I think i remember reading that "abseil shared will compile, but for some reason using it is problematic" which i don't really understand. As such, i would encourage you to build up as much of the stack as you can and try to test it for real. It is possible to use conda forge infrastructure to upload to your own channel. It is great for experimenting purposes considering build locally doesn't work for windows. The manual steps i have to do is activate azure and enter in my binstar token there. |
Fair enough.
The issue is precisely the ABI-impact of the C++ version (and being susceptible to breakage because even the headers that come along with the shared lib can change based on the C++ standard used to compile consuming projects). Most people aren't ready to take on the consequences of doing that, but our abseil unix builds have been shared for quite a while.
I can imagine this using a dev-channel that we can publish to (similar to |
…nda-forge-pinning 2022.09.04.11.55.37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really clean and high quality.
Picking up various improvements from #237, but switching to shared abseil builds on windows now.