-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.20] Build with CMake on unix #127
Conversation
…nda-forge-pinning 2022.09.03.15.06.47
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
cb518e2
to
41bb7b7
Compare
…nda-forge-pinning 2022.09.03.21.29.17
@conda-forge/libprotobuf PTAL We've had a bunch of issues with abseil/grpc and recent migrations, some of which only show up when actually trying to build against the artefacts in other feedstocks (e.g. things around the link interface and what libs are necessary at runtime because of that), so I'd like to run the compilation example from upstream grpc in our CI, see the setup added in conda-forge/grpc-cpp-feedstock#239. However, that example is based on cmake and currently fails because our libprotobuf builds have no cmake metadata. Since upstream protobuf seems to have put much more effort behind CMake (as of 3.21, As I went, I fixed some other issues like improved testing, normalized the location of the cmake metadata on windows, and harmonized the static build setup for windows with the unix ones resp. conda-forge/conda-forge.github.io#1809. I also switched away from travis as it consistently killed the build (not sure if memory demands are too high...?). This PR has a mirror version in #128 for main, but it should be enough to review this one. I've kept as much as possible intact through the various commits, which should be easier to review than the whole diff at once (which loses the files renames). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm new to this feedstock but this looks like a really great improvement @h-vetinari!
Testing things like grpc through the examples provided upstream needs
find_package(protobuf)
to run, which fails on unix withbecause the builds here are done with autotools.
Build with cmake to be able to run better testing in grpc-cpp feedstock. Also: