Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @jakirkham as a maintainer #1

Merged
merged 1 commit into from
Apr 27, 2016
Merged

Add @jakirkham as a maintainer #1

merged 1 commit into from
Apr 27, 2016

Conversation

jakirkham
Copy link
Member

Adds me as a maintainer.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe (might be a conda-smithy bug) 😢

@jakirkham
Copy link
Member Author

Linter is complaining about this line. We can ignore it.

@gillins
Copy link
Contributor

gillins commented Apr 27, 2016

This line came from @patricksnape (see conda-forge/staged-recipes#355) - another workaround to get the right version of VC!

@jakirkham
Copy link
Member Author

No worries. Not saying it should be changed. Quite the opposite. Just noting what is going on for people in the future (or in a few hours 😉).

@jakirkham
Copy link
Member Author

If you have no objections, would you please merge this, @gillins?

@gillins gillins merged commit 3099709 into conda-forge:master Apr 27, 2016
@gillins
Copy link
Contributor

gillins commented Apr 27, 2016

😄 I wonder if there should be a better syntax for getting Python for testing?

@jakirkham
Copy link
Member Author

We are working on a VC package in this PR ( conda-forge/staged-recipes#363 ). It will ultimately replace this Python stuff. Also, it will open the door to other VC versions that don't have a supported CPython version, but are otherwise useful (e.g. building C/C++ projects).

@jakirkham jakirkham deleted the add_jakirkham branch April 27, 2016 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants