add jpeg #355
add jpeg #355
Conversation
|
Hi! This is the friendly conda-forge-admin automated user. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/jpeg:
|
|
Hi! This is the friendly conda-forge-admin automated user. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| - python # [win] | ||
| - cmake # [win] | ||
|
|
||
| test: |
There was a problem hiding this comment.
As mentioned in the cross post, I don't think you need Python for building, but for testing - and you probably need to add a Jinja template to make sure the correct Python is chosen. This should fix the Windows errors.
There was a problem hiding this comment.
OK I think I've got it working under Windows. Which is the Jinja template? appveyor seems to be running all the various versions of Python.
There was a problem hiding this comment.
The Jinja template is here. That should get the builds working. That will fix the fact that only Python 2.7 builds seems to work.
|
@msarahan Obviously Continuum already ship libjpeg - how are the Windows builds currently handled? Do you also use a custom CMake? |
|
Continuum seem to use the makefile.vc that is supplied. However, this builds a static lib that can only be used by executables but not DLLs (ie GDAL). This workaround was the best I could come up with. |
|
@gillins You are totally right, that is very confusing - because packages seem to be able to rely on jpeg and compile yet there is no DLL being created. And I've never set up a package to explicitly statically link jpeg so I'm stumped there. Great work on creating a working CMake for Windows then! I wonder if we need to test that it is exporting the symbols correctly somehow. |
|
That failure is because of 503 errors :( Need to restart the build! |
|
Well the Jinja thing seemed to have fixed it anyway since the Python 3.4 and 3.5 tests passed. Thanks! Is restarting the build something I can do? regarding symbols being exported under Windows: well the fact that the utility programs link seems a good test, but I could write some Python to test a list of function names are in the DLL using ctypes or win32.LoadLibrary if you think it is necessary. |
|
Sorry guys, I have been sick the past couple of days. Confirming that the Continuum recipe only uses makefile.vc - so what you have here should be an improvement. Wherever possible, it would be nice to provide both static and dynamic libraries, so anyone building with our stuff has the option. |
|
Have added static libs for Unix and Windows builds. For Windows the dynamic libs are libjpeg.dll/.lib (the .lib is the import library) and the static lib is jpeg.lib. Not sure if there is a naming convention we should be following here. Is it usual Conda convention to provide both static and dynamic versions? At one stage Ryan Grout seemed to be removing all the static builds. AppVeyor seems happy now BTW. |
It is a conda-forge convention if that is what you mean, yes. We try to catch this and fix it when we can. If there are ones you know that are missing static libraries, feel free to raise an issue on the respective feedstock or note this in the PR to staged-recipes if it hasn't been released yet. |
| @@ -0,0 +1,6 @@ | |||
|
|
|||
|
This looks pretty nice to me. Thoughts from others? We might want to squash the binary commits (pictures and such) so we don't have that stuff lingering in the repo's history. |
👍
@gillins is in Australia, so I don't think anything will be done here in our time-zone. Maybe we could enable squash-your-commits 😉 |
|
Ah, thanks for TZ info. Yeah, was thinking about doing it manually, but that is a good point. |
|
Oh, squash merge is not enabled here. 😮 |
|
I'll do it the old fashion way. |
|
Squashed and added in this PR ( #369 ). |
|
Thanks @gillins for the recipe and @jakirkham for squashing it. |
|
Yeah seems my TZ isn't very sociable... Thanks everyone for all the help getting this merged |
|
No worries. It was easy enough to bring home. Thanks again @gillins. |
Actually, for GitHub interactions, I do like that the PRs sit for a few hours 😉 However, it would be nice to get you in one of our Google Hangouts one day. (See conda-forge/conda-forge.github.io#89 for the last one.) |
Unix build same as conda-recipes.
Had to make some changes to the Windows build to make a DLL - this not supported by provided makefile so use simple cmake script instead that is provided as a patch with this recipe.