Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use double as datatypes and rename package to libccd-double #5

Merged
merged 5 commits into from
Jun 7, 2022

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented May 27, 2022

Implement the idea described in #4 .
I also added a run_constrained condition to ensure that libccd and libccd-double conflict.
I also bumped the build number, strictly speaking it is not necessary but I think it may avoid confusions.
I also added myself to mantainers.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from wolfv as a code owner May 27, 2022 21:16
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: run_constrained: libccd < 1 should not contain a space between relational operator and the version, i.e. libccd <1

@traversaro traversaro changed the title Switch to use double as datatypes and rename package to libccd-double [WIP] Switch to use double as datatypes and rename package to libccd-double May 27, 2022
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro traversaro closed this May 27, 2022
@traversaro traversaro reopened this May 27, 2022
@traversaro traversaro changed the title [WIP] Switch to use double as datatypes and rename package to libccd-double Switch to use double as datatypes and rename package to libccd-double May 27, 2022
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please restart ci

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

@conda-forge/ccd the PR is ready fo review.

@traversaro
Copy link
Contributor Author

@conda-forge/ccd the PR is ready fo review.

Damn, the mention was wrong, the correct one is @conda-forge/libccd (let's also mention @wolfv just to be sure).

@wolfv wolfv merged commit 59a9604 into conda-forge:main Jun 7, 2022
@traversaro
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants