Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-forge CI: Switch from libccd to libccd-double #3315

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

traversaro
Copy link
Collaborator

@traversaro traversaro commented Apr 15, 2023

🦟 Bug fix

Fixes #3313

Summary

In conda-forge, the libccd package contains the (deprecated and not updated) single precision build of libccd, while libccd-double containes the double precision build of libccd.

See conda-forge/libccd-feedstock#5 and conda-forge/gazebo-feedstock#137 .

Pulling libccd was forcing us to use a quite old boost, that in the end created problems.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@traversaro
Copy link
Collaborator Author

The other failures are unrelated, but the macos-latest@Releaase@conda job now is successful, so the PR is ready for merge.

@traversaro traversaro requested review from j-rivero and scpeters April 16, 2023 09:33
@scpeters
Copy link
Member

Thanks Silvio!

@scpeters scpeters merged commit d45feeb into gazebosim:gazebo11 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gazebo-classic "C++ CI Workflow with conda-forge dependencies" job failing since two weeks ago on macOS
2 participants