Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activation scripts to workaround problem in relocatability #27

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 9, 2021

Fix #25 .

The activation scripts are far from perfect, I have opened #26 to track that.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@traversaro
Copy link
Contributor Author

Testing a local version of this package on ign-sensors's examples/save_image, the image is correctly generated on Windows:
image

@traversaro traversaro merged commit 827973b into conda-forge:master Oct 9, 2021
@Tobias-Fischer
Copy link
Contributor

Thanks for this @traversaro! Should we use $PKG_NAME instead of hard coding the name though so it's less work when updating versions?

@traversaro
Copy link
Contributor Author

Thanks for this @traversaro! Should we use $PKG_NAME instead of hard coding the name though so it's less work when updating versions?

Sure! That was what I wanted to track in #26 , for the first version I wanted to minize the possibility of doing something wrong. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some embedded paths are not relocated on Windows
3 participants