-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 6.0.0 #17
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…a-forge-pinning 2021.10.08.08.39.03
A rapid check by adding verbosity to the tests reveals that, as it was the case in conda-forge/libignition-rendering4-feedstock#19 (comment), that the tests that are passing on Windows and Linux are not actually passing, for example on Linux
while on Windows:
Again, as in conda-forge/libignition-rendering4-feedstock#19 (comment) it probably just make sense to try to run the test locally and then merge. |
Just tested on a real macOS machine, indeed the offending tests fail:
Detailed error:
|
All test pass successfully if I set the following env variables:
So probably there is an issue similar to conda-forge/libignition-rendering4-feedstock#25 (comment), just on macOS . |
Note that even after setting those env variables, the test pass but an error is printed:
However, I have the impression that that error is just a spurious error. Indeed, I tried to run the
|
Hopefully conda-forge/libignition-rendering4-feedstock#27 should solve all the problem with the tests, and once that is merge we can merge this PR as well. |
Just tested with |
Great, shall we merge this in? |
Sure! |
This was done manually due to conda-forge/libignition-gazebo-feedstock#24 .
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)