back to autotools build on unix for now #130
Conversation
h-vetinari
requested review from
dopplershift,
hajapy,
jakirkham,
ocefpaf,
wesm,
xhochy and
xylar
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
force-pushed
the
auto_main
branch
from
2b886e1 to
a791734
Compare
| script: build-lib.sh # [unix] | ||
| script: build-shared.sh # [unix] | ||
| # cmake script currently disabled due to compatibility issues with | ||
| # existing builds; see #49 for potential solution, or switch with 3.22 |
There was a problem hiding this comment.
Switching with 3.22 is not a good idea. We want to be able to switch between cmake and autotools build if the need arises. Therefore #49 is the best way forward.
There was a problem hiding this comment.
Please see this comment. Upstream already aligned the names and soversions, but it still broke.
I also don't see the benefit of being able to switch back to autotools. It just a large surface for breakage for very little gain AFAICT, especially now that upstream has graduated CMake to first class citizen.
There was a problem hiding this comment.
Please see this #68 (comment).
I know. Please see my comment on #49 about fixing protobuf_SO_VERSION and other variables.
I also don't see the benefit of being able to switch back to autotools. It just a large surface for breakage for very little gain AFAICT, especially now that upstream has graduated CMake to first class citizen.
AFAICT, CMake was not a first class citizen up-to-now. If that becomes the default installation, that is fine.
There was a problem hiding this comment.
Upstream already aligned the names and soversions, but it still broke.
Yes, it was done by someone without a good understanding of how autotools works. I specifically added a feature to CMake to make it easier to replicate autotools behaviour because of protobuf.
There was a problem hiding this comment.
AFAICT, CMake was not a first class citizen up-to-now. If that becomes the default installation, that is fine.
That is how I interpret protocolbuffers/protobuf#9596
FYI, autotools was removed completely from the upcoming v3.22. Salient quote:
|
Undo effects of #128, see post-merge discussion there.