CMakeLists.txt should be in top-level directory

[Arfrever]

The standard practice is to put main CMakeLists.txt in top-level directory, not in subdirectory called cmake or similar.
Some examples of projects:
abseil-cpp
gflags
glog

I would suggest to move Protobuf's cmake/CMakeLists.txt to top-level directory and adjust appropriate paths.
If there is agreement with this suggestion, then I can try to work on it.

[acozzette]

Is there a way to do this without breaking scripts that rely on the existing location? Maybe we could leave a symlink at the old location if that works.

[bsergean]

Old versions of Windows don't support symlinks, but newer might. It would be great if the Cmakefile was usable on linux/mac as well.

[Arfrever]

cmake/CMakeLists.txt can become a small regular file with few lines:

cmake_minimum_required(VERSION 3.5)

message(WARNING "Calling of cmake with Protocol Buffers' \"cmake\" subdirectory as source directory is deprecated. Top-level directory should be used instead.")

project(protobuf C CXX)

set(protobuf_DEPRECATED_CMAKE_SUBDIRECTORY_USAGE TRUE)

include(../CMakeLists.txt)

[bsergean]

Nice, that’s much in my opinion to the symlink approach.

…

On Mar 8, 2022, at 2:06 AM, Arfrever ***@***.***> wrote: cmake/CMakeLists.txt can become a small regular file with few lines: cmake_minimum_required(VERSION 3.5) message(WARNING "Calling of cmake with Protocol Buffers' \"cmake\" subdirectory as source directory is deprecated. Top-level directory should be used instead.") project(protobuf C CXX) set(protobuf_DEPRECATED_CMAKE_SUBDIRECTORY_USAGE TRUE) include(../CMakeLists.txt) — Reply to this email directly, view it on GitHub <#9596 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O6UKGGKWSGTP3D7LVV5DU64RC5ANCNFSM5QE7W2GQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.

[acozzette]

Yeah, that looks like a good way to do it!