-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use namespaced absl::abseil_dll imported target instead of abseil_dll to correctly propagate CMake usage requirements defined in abseil build on Windows #162
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/libprotobuf-feedstock/actions/runs/5168822075. |
Could you adapt the CMake test to load that target |
Sure! I did not fully understand why it is necessary to link a different target on Windows w.r.t. to Unix system, but it should be trivial to add a test. |
Now that I think of, the |
The test is passing fine:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this (also upstream)!
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Backport of protocolbuffers/protobuf#12978 to fix build failure on Windows such as conda-forge/libignition-msgs1-feedstock#86 (comment) .
xref: conda-forge/conda-forge-pinning-feedstock#4075
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)