CMake: Fix abseil_dll target name when using find_package(absl) #12978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2023
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
This additional if is necessary as of abseil 20230125.3 when abseil is consumed via add_subdirectory, the abseil_dll target is named abseil_dll, while if abseil is consumed via find_package, the target is called `absl::abseil_dll` . Once abseil/abseil-cpp#1466 is merged and released in the minimum version of abseil required by protobuf, it is possible to always link `absl::abseil_dll` and `absl::abseil_test_dll` and remove the if. You may wonder how linking worked at all before when `protobuf_ABSL_PROVIDER STREQUAL "package"`, as `abseil_dll` was not an imported target defined by `find_package(absl)`. The reason behind this is that if a name that is not an imported target is passed to `target_link_libraries`, it is just regarded as a C++ library name. So, in the end the `abseil_dll` library was correctly linked, simply all the transitive usage requirements defined by the `absl::abseil_dll` target were not propagated, that could lead to compilation errors if abseil was compiled with the `ABSL_PROPAGATE_CXX_STD` CMake option enabled. Closes #12978 COPYBARA_INTEGRATE_REVIEW=#12978 from traversaro:patch-1 39dd074 FUTURE_COPYBARA_INTEGRATE_REVIEW=#12978 from traversaro:patch-1 39dd074 PiperOrigin-RevId: 537953985
h-vetinari
pushed a commit
to h-vetinari/protobuf
that referenced
this pull request
Jun 5, 2023
…ocolbuffers#12978) This additional if is necessary as of abseil 20230125.3 when abseil is consumed via add_subdirectory, the abseil_dll target is named abseil_dll, while if abseil is consumed via find_package, the target is called `absl::abseil_dll` . Once abseil/abseil-cpp#1466 is merged and released in the minimum version of abseil required by protobuf, it is possible to always link `absl::abseil_dll` and `absl::abseil_test_dll` and remove the if. You may wonder how linking worked at all before when `protobuf_ABSL_PROVIDER STREQUAL "package"`, as `abseil_dll` was not an imported target defined by `find_package(absl)`. The reason behind this is that if a name that is not an imported target is passed to `target_link_libraries`, it is just regarded as a C++ library name. So, in the end the `abseil_dll` library was correctly linked, simply all the transitive usage requirements defined by the `absl::abseil_dll` target were not propagated, that could lead to compilation errors if abseil was compiled with the `ABSL_PROPAGATE_CXX_STD` CMake option enabled. Closes protocolbuffers#12978 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#12978 from traversaro:patch-1 39dd074 PiperOrigin-RevId: 537990391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additional if is necessary as of abseil 20230125.3 when abseil is consumed via add_subdirectory,
the abseil_dll target is named abseil_dll, while if abseil is consumed via find_package, the target is called
absl::abseil_dll.Once abseil/abseil-cpp#1466 is merged and released in the minimum version of abseil required by protobuf, it is possible to always link
absl::abseil_dllandabsl::abseil_test_dlland remove the if.You may wonder how linking worked at all before when
protobuf_ABSL_PROVIDER STREQUAL "package", asabseil_dllwas not an imported target defined byfind_package(absl). The reason behind this is that if a name that is not an imported target is passed totarget_link_libraries, it is just regarded as a C++ library name. So, in the end theabseil_dlllibrary was correctly linked, simply all the transitive usage requirements defined by theabsl::abseil_dlltarget were not propagated, that could lead to compilation errors if abseil was compiled with theABSL_PROPAGATE_CXX_STDCMake option enabled.