Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not merge: Apply upstream aarch64 consecutive register fix (11.x) #167

Closed
wants to merge 5 commits into from

Conversation

hmaarrfk
Copy link

Closes #164

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Author

@conda-forge-admin please rerender

Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an ABI breakage. See the last comment in https://bugs.llvm.org/show_bug.cgi?id=46996

@hmaarrfk
Copy link
Author

Thank you for pointing this out. I'm going to let this run, to see if holding back the compiler helps osx for educational purposes.

@hmaarrfk hmaarrfk marked this pull request as draft August 20, 2022 21:18
@hmaarrfk hmaarrfk changed the title Apply upstream aarch64 consecutive register fix (11.x) Do not merge: Apply upstream aarch64 consecutive register fix (11.x) Aug 20, 2022
@hmaarrfk
Copy link
Author

Seems like OSX didn't get fixed from this.

@hmaarrfk hmaarrfk closed this Aug 21, 2022
@gmarkall
Copy link

This is an ABI breakage. See the last comment in https://bugs.llvm.org/show_bug.cgi?id=46996

Isn't that only the case when the LLVM 12-specific version of the patch is applied to LLVM 12? It looks like the version applied to the LLVM 11 branch was OK: https://bugs.llvm.org/show_bug.cgi?id=46996#c9

@isuruf
Copy link
Member

isuruf commented Aug 22, 2022

Why do you think it's not an ABI breakage for LLVM 11? The patch for LLVM 11 changes the signature for a public method which changes the name mangling and therefore is an ABI breakage

@gmarkall
Copy link

Why do you think it's not an ABI breakage for LLVM 11? The patch for LLVM 11 changes the signature for a public method which changes the name mangling and therefore is an ABI breakage

Thanks for the clarification, I was wrong about this. I'd misunderstood some of the discussion on the LLVM bug which lead me to believe that the ABI was the same for LLVM 11 but differed for LLVM 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants