numba v0.56.2 #94

regro-cf-autotick-bot · 2022-07-25T22:26:14Z

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Dependencies have been updated if changed: see upstream
Tests have passed
Updated license if changed and license_file is packaged

Information about this PR:

Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.
The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :( Help is very welcome!

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2735386165, please use this URL for debugging.}

Closes #98
Closes #99
Closes #101

…nda-forge-pinning 2022.07.25.20.17.58

conda-forge-linter · 2022-07-25T22:26:18Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

henryiii · 2022-07-27T16:25:43Z

I’ve been traveling for a few weeks (including SciPy) and should be back at a computer tomorrow!

jakirkham · 2022-07-27T20:07:44Z

No worries. Also we probably need the llvmlite update to proceed ( conda-forge/llvmlite-feedstock#62 ), which is blocked atm due to Windows issues.

jakirkham · 2022-08-12T18:15:03Z

@conda-forge-admin, please re-render

…nda-forge-pinning 2022.08.11.23.35.06

Drop patch as this has been upstreamed.

jakirkham · 2022-08-12T19:15:19Z

Now that llvmlite is out, have updated this PR with the latest version constraints. Though there were a few changes. So would be good to have a few more eyes on it 🙂

jakirkham · 2022-08-12T19:15:29Z

cc @stuartarchibald (for awareness)

jakirkham · 2022-08-12T19:32:07Z

Note: The aarch64 builds are currently timing out.

hmaarrfk · 2022-08-13T00:05:43Z

It doesn't seem like the yare timing out as much as just using too many cores and crashing the tests.

recipe/meta.yaml

henryiii · 2022-08-14T17:38:35Z

Looks like this is segfaulting on all CPython on ARM?

jakirkham · 2022-08-18T09:05:49Z

Should add llvmlite in conda-forge uses shared libraries from LLVM. So we shouldn't need to rebuild it. Just need to rebuild LLVM (insert appropriate LOTR meme)

hmaarrfk · 2022-08-20T22:31:08Z

Seems that applying that patch is not ABI compatibile.

stuartarchibald · 2022-08-22T09:15:13Z

Seems that applying that patch is not ABI compatibile.

Does the ABI incompatibility only concern LLVM 12+, whereas Numba needs LLVM 11?

hmaarrfk · 2022-08-22T15:31:33Z

FYI, i think the meat of the discussion about ABI breakage is happening: conda-forge/llvmdev-feedstock#167 (review)

njriasan · 2022-09-06T20:32:37Z

Is there any update on this release?

stuartarchibald · 2022-09-07T07:52:09Z

Is there any update on this release?

I think it's waiting on resolving issues in the llvmdev package for LLVM 11 on aarch64.

raybellwaves · 2022-09-19T02:56:00Z

latest may be related to this PR: conda-forge/llvmdev-feedstock#171

hmaarrfk · 2022-09-19T17:46:56Z

It is mostly waiting on final review from: conda-forge/llvmdev-feedstock#170

jakirkham · 2022-09-28T07:19:10Z

@conda-forge-admin, please re-render

…nda-forge-pinning 2022.09.27.08.36.12

jakirkham · 2022-09-28T07:25:16Z

recipe/meta.yaml


 run:
 - python
 - {{ pin_compatible('llvmlite', max_pin='x.x') }}
 - {{ pin_compatible('numpy') }}
+ - importlib-metadata # [py < 39]
 # needed for pkg_resources
 - setuptools


Noticed setuptools is constrained to <60 in requirements. Why was this needed?

Originally we noticed that there was a problem with setuptools 65 (Numba issue: numba/numba#8355). NumPy produced a deprecation warning stating:

`numpy.distutils` is deprecated since NumPy 1.23.0, as a result of the deprecation of `distutils` itself. It will be removed for Python >= 3.12. For older Python versions it will remain present. It is recommended to use `setuptools < 60.0` for those Python versions. For more details, see: https://numpy.org/devdocs/reference/distutils_status_migration.html

This is why we constrained it to <60. However, this does cause other issues, as noted in numba/numba#8366 (comment).

The plan is to make setuptools an optional runtime dependency in Numba, and not pin to any specific version (see numba/numba#8366 (comment)) - so I think it will be OK not to constrain to any specific setuptools version, as long as the packages build successfully.

Gotcha. Maybe we can add the constraint to host.

It looks like outside of building, setuptools is only really used in tests. Is that right? If so, maybe we can add the constraint to test requirements.

Wondering if we can drop setuptools from run. Or at least not add the constraint there (as that may be disruptive to users).

Edit: Should add the comment above suggests setuptools was needed for pkg_resources. Though am not seeing pkg_resources used in Numba atm. Is that correct or am I missing something?

setuptools is needed by the pycc tool, so it needs to be installed alongside Numba, otherwise someone who installs Numba and tries to run pycc for ahead-of-time compilation will run into an issue - setuptools still needs to be part of run.

I think pkg_resources is not used in Numba at present.

Gotcha. Is pycc using numpy.distutils or just distutils (and setuptools ofc)?

As we are diverging here now from the official package constraints, this sadly causes all packages that depend on numba to have a failing pip check. I would argue that we should align with upstream here. If numba (maintainers) thinks this is not an issue, then it should be removed upstream (as done in one of the linked PRs which probably takes a bit longer). As long as upstream defines this constraint and it is in the pip metadata, we should reflect that in the conda metadata. I went ahead and made a PR to address that: #104

I think this should match NumPy (in Numba upstream). NumPy does not require setuptools<60, so Numba should not either. It's really serious to limit to <60, since 61-62 added pyproject.toml config, so I'm expecting to see a growing number of setuptools minimums around that level.

Also, there's a pretty trivial fix for setuptools >60. It's not a real requirement.

Why does our pip check pass but not others?

I do see it here. 😱

Why does our pip check pass but not others?

Probably because there is a run_test.sh the entries in test: commands: … are not executed. I don't see it in the logs.

Numba version 0.56.3 has been released with no restrictions on the setuptools version so as to address this issue. Thanks for the feedback.

jakirkham · 2022-09-28T07:29:49Z

With PR ( conda-forge/llvmdev-feedstock#171 ) in, refreshed this PR. Updated to the latest version and updated requirements. There was a setuptools version constraint that I was unsure about. Asked about this above. Please take a look and let us know if anything else is needed here.

recipe/run_test.sh

gmarkall

I think this is looking good now:

The AArch64 consecutive registers patch in llvmdev appears to have resolved the AArch64 issues.
I don't think the setuptools pin is necessary (and it would indeed be problematic to pin it in other ways)

henryiii

Looks good, and agree about avoiding a runtime pin on setuptoools.

jakirkham · 2022-09-28T17:12:16Z

Thanks all! 🙏 Let's get these packages out

jakirkham · 2022-09-28T18:56:03Z

Looks like all of the ppc64le jobs on main timed out on CI. This wasn't an issue in the PR previously. Trying restarting them...

Edit: They are still failing. Raised issue ( #102 )

regro-cf-autotick-bot added 2 commits July 25, 2022 22:25

updated v0.56.0

6de90fc

MNT: Re-rendered with conda-build 3.21.9, conda-smithy 3.21.0, and co…

e2e14bb

…nda-forge-pinning 2022.07.25.20.17.58

regro-cf-autotick-bot requested review from henryiii, jakirkham, marcelotrevisani, mbargull, souravsingh and step21 as code owners July 25, 2022 22:26

jpn-- mentioned this pull request Aug 12, 2022

Fix numpy ActivitySim/activitysim#584

Closed

Bump llvmlite to 0.39

c3e6f56

conda-forge-webservices[bot] and others added 6 commits August 12, 2022 18:16

MNT: Re-rendered with conda-build 3.22.0, conda-smithy 3.21.1, and co…

72d434a

…nda-forge-pinning 2022.08.11.23.35.06

Delete patch-parfor.patch

f56c0f3

Drop patch as this has been upstreamed.

Drop upstreamed patch

18d8635

Update dependencies

71af88d

Update numpy constraint

2e4a5c7

Fix host dependency constraint

e94026a

hmaarrfk added 3 commits August 12, 2022 20:08

Limit CPU count on aarch64

ea40fb1

better package name for importlib-metadata

ece66e7

run tests on PPC as well since the issue was resolved

a4863a6

hmaarrfk reviewed Aug 14, 2022

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

henryiii mentioned this pull request Aug 14, 2022

Rebuidl with llvmlite 0.39 #96

Closed

1 task

This was referenced Sep 2, 2022

numba v0.56.1 #98

Closed

numba v0.56.2 #99

Closed

david-zwicker mentioned this pull request Sep 10, 2022

py-pde v0.22.0 conda-forge/py-pde-feedstock#36

Closed

3 tasks

henryiii mentioned this pull request Sep 19, 2022

WIP: 0.56.2; bump upper numpy limit to 1.24 #101

Closed

5 tasks

raybellwaves mentioned this pull request Sep 19, 2022

build failing for 0.56.2 #100

Closed

1 task

Update to 0.56.2

d8ec1c0

MNT: Re-rendered with conda-build 3.22.0, conda-smithy 3.21.1, and co…

5b2167f

…nda-forge-pinning 2022.09.27.08.36.12

jakirkham reviewed Sep 28, 2022

View reviewed changes

jakirkham changed the title ~~numba v0.56.0~~ numba v0.56.2 Sep 28, 2022

gmarkall reviewed Sep 28, 2022

View reviewed changes

recipe/run_test.sh Outdated Show resolved Hide resolved

Go back to using 4 procs to test ARM

624e079

gmarkall approved these changes Sep 28, 2022

View reviewed changes

henryiii approved these changes Sep 28, 2022

View reviewed changes

jakirkham merged commit 4794b31 into conda-forge:main Sep 28, 2022

regro-cf-autotick-bot deleted the 0.56.0_h5e4d67 branch September 28, 2022 17:13

jakirkham mentioned this pull request Sep 28, 2022

Numba 0.56.2 ppc64le builds failing on main #102

Open

xhochy mentioned this pull request Sep 29, 2022

Pin setuptools<60 #104

Closed

5 tasks

henryiii mentioned this pull request Sep 29, 2022

Update setup.py, buildscripts, CI and docs to require setuptools<60. numba/numba#8356

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

numba v0.56.2 #94

numba v0.56.2 #94

regro-cf-autotick-bot commented Jul 25, 2022 •

edited by jakirkham

Loading

conda-forge-linter commented Jul 25, 2022

henryiii commented Jul 27, 2022

jakirkham commented Jul 27, 2022

jakirkham commented Aug 12, 2022

jakirkham commented Aug 12, 2022

jakirkham commented Aug 12, 2022

jakirkham commented Aug 12, 2022

hmaarrfk commented Aug 13, 2022

henryiii commented Aug 14, 2022

jakirkham commented Aug 18, 2022

hmaarrfk commented Aug 20, 2022

stuartarchibald commented Aug 22, 2022

hmaarrfk commented Aug 22, 2022

njriasan commented Sep 6, 2022

stuartarchibald commented Sep 7, 2022

raybellwaves commented Sep 19, 2022

hmaarrfk commented Sep 19, 2022

jakirkham commented Sep 28, 2022

jakirkham Sep 28, 2022

gmarkall Sep 28, 2022

jakirkham Sep 28, 2022 •

edited

Loading

gmarkall Sep 28, 2022

jakirkham Sep 28, 2022

xhochy Sep 29, 2022

henryiii Sep 29, 2022

henryiii Sep 29, 2022

xhochy Sep 29, 2022

stuartarchibald Oct 14, 2022

jakirkham commented Sep 28, 2022

gmarkall left a comment

henryiii left a comment

jakirkham commented Sep 28, 2022

jakirkham commented Sep 28, 2022 •

edited

Loading

numba v0.56.2 #94

numba v0.56.2 #94

Conversation

regro-cf-autotick-bot commented Jul 25, 2022 • edited by jakirkham Loading

Dependency Analysis

conda-forge-linter commented Jul 25, 2022

henryiii commented Jul 27, 2022

jakirkham commented Jul 27, 2022

jakirkham commented Aug 12, 2022

jakirkham commented Aug 12, 2022

jakirkham commented Aug 12, 2022

jakirkham commented Aug 12, 2022

hmaarrfk commented Aug 13, 2022

henryiii commented Aug 14, 2022

jakirkham commented Aug 18, 2022

hmaarrfk commented Aug 20, 2022

stuartarchibald commented Aug 22, 2022

hmaarrfk commented Aug 22, 2022

njriasan commented Sep 6, 2022

stuartarchibald commented Sep 7, 2022

raybellwaves commented Sep 19, 2022

hmaarrfk commented Sep 19, 2022

jakirkham commented Sep 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham Sep 28, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Sep 28, 2022

gmarkall left a comment

Choose a reason for hiding this comment

henryiii left a comment

Choose a reason for hiding this comment

jakirkham commented Sep 28, 2022

jakirkham commented Sep 28, 2022 • edited Loading

regro-cf-autotick-bot commented Jul 25, 2022 •

edited by jakirkham

Loading

jakirkham Sep 28, 2022 •

edited

Loading

jakirkham commented Sep 28, 2022 •

edited

Loading