-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvmlite v0.39.0 #62
llvmlite v0.39.0 #62
Conversation
…nda-forge-pinning 2022.07.26.20.23.31
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
@stuartarchibald, do you know if this Windows patch made it upstream? Asking as it appears to have conflicts applying on CI |
@jakirkham AFAIK it's not in upstream. It looks familiar though, is this due to differences in the way Anaconda distro and conda-forge cpython binaries search for libraries on windows Py3.8? |
@mbargull, do you know if we still need the Windows patch above? Looks like it is not applying correctly on the latest release. |
@marcelotrevisani, do you know if we still need this Windows patch? If so, it appears to need updates to ensure it is able to apply Note: It appears this patch was added in PR ( #32 ) |
….patch Try deleting this patch to see whether it is still needed.
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
Drop unused patch.
@conda-forge-admin, please re-render. |
…nda-forge-pinning 2022.08.09.15.26.55
Going to just try dropping the patches and see how that goes |
All the jobs passed except for one of the macOS builds, which failed somewhat mysteriously. Attached the log from CI for posterity. Given the patches dropped are not related to macOS and none of the other builds failed, trying to restart that build to see if that fixes the issue. |
Still seeing test failures with macOS Python 3.7. Here's the failure: ======================================================================
ERROR: test_libm (llvmlite.tests.test_binding.TestDylib)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/runner/miniforge3/conda-bld/llvmlite_1660068433388/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.7/site-packages/llvmlite/tests/test_binding.py", line 1644, in test_libm
llvm.load_library_permanently(libm)
File "/Users/runner/miniforge3/conda-bld/llvmlite_1660068433388/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.7/site-packages/llvmlite/binding/dylib.py", line 29, in load_library_permanently
_encode_string(filename), outerr):
File "/Users/runner/miniforge3/conda-bld/llvmlite_1660068433388/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.7/site-packages/llvmlite/binding/common.py", line 5, in _encode_string
encoded = s.encode('utf-8')
AttributeError: 'NoneType' object has no attribute 'encode'
---------------------------------------------------------------------- Log from CI attached for posterity. Edit: Was able to reproduce the issue with Python 3.7 on macOS. Filed as upstream issue ( conda-forge/python-feedstock#575 ). Edit 2: Looks like this came up in Edit 3: PR ( numba/llvmlite#870 ) contains a patch to disable the test here. |
@stuartarchibald, is there an easy way to disable this test? If not, suppose we can patch it out instead |
@jakirkham Unfortunately I don't think there's a way to disable this test short of patching it out. Numba is going to get a 0.56.1 release to support NumPy 1.23, I'm going to propose to the core devs that llvmlite also gets a point release with this test patched out under macOS. |
Thanks Stuart! 🙏 That would be very helpful. Am ok either patching this out manually on our end or waiting for the point release, whichever is preferred 🙂 |
@jakirkham no problem. I think the point release may be order of weeks (need to get NumPy 1.23 working and tested), though may be quicker, so if you are interested in shipping a Numba 0.56/llvmlite 0.39 series sooner I'd go with the patch. |
Add patch to disable `test_libm` on macOS.
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
patches: | ||
- 0001-Add-add_dll_directory-for-LIBRARY_BIN-for-Py38-on-Windows.patch # [win and py>=38] | ||
# https://github.com/conda-forge/llvmlite-feedstock/pull/62#issuecomment-1209762518 | ||
- patches/0001-Disable-test_libm-on-macOS.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch is also in PR ( numba/llvmlite#870 ) for reference.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.
Packages found by source code inspection but not in the meta.yaml:
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2742172757, please use this URL for debugging.