Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmlite v0.39.0 #62

Merged
merged 9 commits into from
Aug 12, 2022

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • versioneer-518

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2742172757, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Jul 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham
Copy link
Member

@stuartarchibald, do you know if this Windows patch made it upstream? Asking as it appears to have conflicts applying on CI

@stuartarchibald
Copy link

@stuartarchibald, do you know if this Windows patch made it upstream? Asking as it appears to have conflicts applying on CI

@jakirkham AFAIK it's not in upstream. It looks familiar though, is this due to differences in the way Anaconda distro and conda-forge cpython binaries search for libraries on windows Py3.8?

@jakirkham
Copy link
Member

@mbargull, do you know if we still need the Windows patch above? Looks like it is not applying correctly on the latest release.

@jakirkham
Copy link
Member

jakirkham commented Aug 9, 2022

@marcelotrevisani, do you know if we still need this Windows patch? If so, it appears to need updates to ensure it is able to apply

Note: It appears this patch was added in PR ( #32 )

….patch

Try deleting this patch to see whether it is still needed.
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Aug 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render.

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Aug 9, 2022
@jakirkham
Copy link
Member

Going to just try dropping the patches and see how that goes

@jakirkham jakirkham added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Aug 9, 2022
@jakirkham
Copy link
Member

All the jobs passed except for one of the macOS builds, which failed somewhat mysteriously. Attached the log from CI for posterity. Given the patches dropped are not related to macOS and none of the other builds failed, trying to restart that build to see if that fixes the issue.

@jakirkham
Copy link
Member

jakirkham commented Aug 9, 2022

Still seeing test failures with macOS Python 3.7. Here's the failure:

======================================================================
ERROR: test_libm (llvmlite.tests.test_binding.TestDylib)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/miniforge3/conda-bld/llvmlite_1660068433388/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.7/site-packages/llvmlite/tests/test_binding.py", line 1644, in test_libm
    llvm.load_library_permanently(libm)
  File "/Users/runner/miniforge3/conda-bld/llvmlite_1660068433388/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.7/site-packages/llvmlite/binding/dylib.py", line 29, in load_library_permanently
    _encode_string(filename), outerr):
  File "/Users/runner/miniforge3/conda-bld/llvmlite_1660068433388/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.7/site-packages/llvmlite/binding/common.py", line 5, in _encode_string
    encoded = s.encode('utf-8')
AttributeError: 'NoneType' object has no attribute 'encode'

----------------------------------------------------------------------

Log from CI attached for posterity.

Edit: Was able to reproduce the issue with Python 3.7 on macOS. Filed as upstream issue ( conda-forge/python-feedstock#575 ).

Edit 2: Looks like this came up in llvmlite before ( numba/llvmlite#752 ). Detailed findings in comment ( numba/llvmlite#752 (comment) ).

Edit 3: PR ( numba/llvmlite#870 ) contains a patch to disable the test here.

@jakirkham
Copy link
Member

@stuartarchibald, is there an easy way to disable this test? If not, suppose we can patch it out instead

@stuartarchibald
Copy link

@stuartarchibald, is there an easy way to disable this test? If not, suppose we can patch it out instead

@jakirkham Unfortunately I don't think there's a way to disable this test short of patching it out. Numba is going to get a 0.56.1 release to support NumPy 1.23, I'm going to propose to the core devs that llvmlite also gets a point release with this test patched out under macOS.

@jakirkham
Copy link
Member

Thanks Stuart! 🙏

That would be very helpful. Am ok either patching this out manually on our end or waiting for the point release, whichever is preferred 🙂

@stuartarchibald
Copy link

Thanks Stuart! pray

That would be very helpful. Am ok either patching this out manually on our end or waiting for the point release, whichever is preferred slightly_smiling_face

@jakirkham no problem. I think the point release may be order of weeks (need to get NumPy 1.23 working and tested), though may be quicker, so if you are interested in shipping a Numba 0.56/llvmlite 0.39 series sooner I'd go with the patch.

Add patch to disable `test_libm` on macOS.
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Aug 12, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Aug 12, 2022
Comment on lines 13 to +15
patches:
- 0001-Add-add_dll_directory-for-LIBRARY_BIN-for-Py38-on-Windows.patch # [win and py>=38]
# https://github.com/conda-forge/llvmlite-feedstock/pull/62#issuecomment-1209762518
- patches/0001-Disable-test_libm-on-macOS.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch is also in PR ( numba/llvmlite#870 ) for reference.

@github-actions github-actions bot merged commit 374b199 into conda-forge:main Aug 12, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.39.0_h7e66b7 branch August 12, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants