Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin setuptools<60 #104

Closed
wants to merge 1 commit into from
Closed

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Sep 29, 2022

See numba/numba@454fe25

This fixes all the failing pip check calls in downstream packages.

Related discussion in yesterday

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy xhochy mentioned this pull request Sep 29, 2022
3 tasks
@henryiii
Copy link
Contributor

Upstream is planning on removing this dependency as required (and that forces it to be unlimited). I think the best action is to patch out the limit here.

@jakirkham
Copy link
Member

If we want to add to host and test/requires, that seems ok. Based on discussion starting here ( #94 (comment) ), we've decided not to do this in run as it would cause different kinds of user pain

As Henry already noted, upstream is working to eliminate this dependency

@henryiii
Copy link
Contributor

henryiii commented Sep 29, 2022

But host and test/requires doesn't affect downstream users, it would not fix the pip check issues. And Numba does support newer setuptools except for 65.0.0 and 65.0.1 due to the removal of msvccompiler that was reverted later. So there's no harm in this, but no benefit either.

#105 fixes pip check to show the issue. I believe the correct fix (building on that one) would be to patch setup.py to remove this limit. Upstream plans to remove this as a requirement, which means it can't be constrained anymore from their end (since pip doesn't have optional constraints).

@gmarkall
Copy link
Contributor

I believe the correct fix (building on that one) would be to patch setup.py to remove this limit.

An attempt at this is in #106.

@henryiii henryiii mentioned this pull request Sep 29, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants