Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #51

Merged
merged 12 commits into from
Oct 6, 2018

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is likely this feedstock needs to be rebuilt.
Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:
adept
armadillo
bob.math
caffe
casacore
And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bgruening
Copy link

Upps Program received signal SIGSEGV: Segmentation fault - invalid memory reference.

@jakirkham
Copy link
Member

This is the CircleCI build. Also attached the log file.

@mariusvniekerk
Copy link
Member

mariusvniekerk commented Sep 18, 2018

There are a few patches in the AnacondaRecipes version that we may need.

The main thing seems to be we are missing the USE_OPENMP="1" environment variable setting as suggested here OpenMathLib/OpenBLAS#218

@jakirkham
Copy link
Member

Looks like issue ( OpenMathLib/OpenBLAS#579 ).

cc @mingwandroid

@jakirkham
Copy link
Member

Think those are the patches that we added to build on Windows. We should already have all of them. Is there one you see we are missing?

@jakirkham
Copy link
Member

This commit ( AnacondaRecipes@a6b3811 ) looks promising.

@jakirkham
Copy link
Member

Would discourage using OpenMP here as Python multiprocessing uses forking, which is known to cause segfaults with GOMP. The error one gets is very unfriendly (program crashes randomly). One could produce this simply by importing numpy and then forking.

ref: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58378

@mariusvniekerk
Copy link
Member

https://github.com/xianyi/OpenBLAS/wiki/faq#Linux_SEGFAULT

@jakirkham
Copy link
Member

Yeah, was also reading that. Either trying to disable TLS or using that patch is a good idea. Possibly both.

@mariusvniekerk
Copy link
Member

guess we need both

AnacondaRecipes@a6b3811

turn TLS off (prematurely enabled by default)

# Conflicts:
#	recipe/meta.yaml
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

As we are now patching the build a bit, deploy a new package for the
legacy toolchain as well.
@jakirkham
Copy link
Member

Thanks for exploring this Marius. 😄

Raised issue ( OpenMathLib/OpenBLAS#1766 ) to see if we can set USE_TLS=0 in the future.

cherry-picked from AnacondaRecipes@2bac9af

# Conflicts:
#	recipe/build.sh
#	recipe/meta.yaml
@mingwandroid
Copy link

Is it possible to add a test for the fork issue? I'd be tempted to apply @njsmith's patch for libgomp here instead, Nathaniel, can you comment on this idea if you have time please?

@jakirkham
Copy link
Member

It might be checking whether USE_OPENMP is defined instead of its value. Leaving it undefined may fix it.

@jakirkham
Copy link
Member

Wouldn’t the patch need to go in the GCC build? Does it still apply cleanly?

@njsmith
Copy link

njsmith commented Sep 18, 2018

I haven't looked at that patch in years, so no idea if it still applies cleanly. Also, does conda even distribute its own openmp runtime libraries? I thought those were part of libgcc or something...

@mariusvniekerk
Copy link
Member

conda does distribute its own libgcc ....

@mingwandroid
Copy link

Also, does conda even distribute its own openmp runtime libraries?

Yes, 'AD' provides its own in the libgcc-ng_linux-* packages.

@mariusvniekerk
Copy link
Member

@isuruf Can you help this poor recipe out?

@isuruf
Copy link
Member

isuruf commented Oct 6, 2018

This shouldn't affect windows

@isuruf isuruf merged commit 1b6ca5a into conda-forge:master Oct 6, 2018
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild branch October 7, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants