Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anaconda recipes sync #52

Closed
wants to merge 5 commits into from
Closed

Anaconda recipes sync #52

wants to merge 5 commits into from

Conversation

mariusvniekerk
Copy link
Member

@mariusvniekerk mariusvniekerk commented Sep 18, 2018 •
edited
Loading

This is an attempt to match AnacondaRecipes . related to #51

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The home item is expected in the about section.
  • The license item is expected in the about section.
  • The summary item is expected in the about section.
  • The outputs section contained an unexpected subsection name. run_exports is not a valid subsection name.

For recipe:

  • It looks like the 'openblas-devel' output doesn't have any tests.
  • It looks like the 'openblas' output doesn't have any tests.
  • It looks like the 'blas' output doesn't have any tests.
  • It looks like the 'nomkl' output doesn't have any tests.

isuruf
isuruf reviewed Sep 18, 2018
View reviewed changes
recipe/0001-remove-hardcoded-make.patch
-CC = gcc
-CFLAGS = -O3
+# CC = gcc
+# CFLAGS = -O3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you do this for toolchain, you'll be compiling with -O0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to see if it builds for linux gfortran at all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this means -O2

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The home item is expected in the about section.
  • The license item is expected in the about section.
  • The summary item is expected in the about section.
  • The outputs section contained an unexpected subsection name. run_exports is not a valid subsection name.

For recipe:

  • It looks like the 'openblas-devel' output doesn't have any tests.
  • It looks like the 'openblas' output doesn't have any tests.

@mariusvniekerk
Copy link
Member Author

@jakirkham Ironically this fails on EVERYTHING aside from gcc7

@ocefpaf ocefpaf mentioned this pull request May 28, 2019
Closed
@ocefpaf
Copy link
Member

ocefpaf commented May 29, 2019

Let's go with #70.

@ocefpaf ocefpaf closed this May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariusvniekerk @conda-forge-linter @ocefpaf @isuruf