-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bot-automerge] pinocchio v3.0.0 #117
[bot-automerge] pinocchio v3.0.0 #117
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly conda-forge automerge bot! It appears that not all commits to this PR were made by the bot. Thus this PR is not being automatically merged. Please add the |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please restart ci |
@conda-forge-admin, please restart ci |
Congrats on the new release! The pypy builds are blocked (also) on conda-forge/casadi-feedstock#109, I guess casadi needs (at least) some CMake fixes for working with pypy. Regarding the cppad pin, do you have any reference to the issue that needs that? Unfortunately pinning cppad to such an older version means that other software in conda-forge that depends on cppad will not be installable with pinocchio 3. A possible alternative is to pin cppad to an older version in https://github.com/conda-forge/conda-forge-pinning-feedstock, to ensure that all conda-forge recipes use the same (older) cppad version. |
Hello @traversaro, I think casadi need proxsuite to be built on pypy. For cppad here the issue. cppad 2024 have added max_digits10 member in CppAD::numeric_limits specialization for CppAD::AD. cppadcodegen has not been released since and one of his specialization for the cg::CG type don't contains In short, last cppadcodgen can only build with cppad 2023. We should patch and release cppadcodgen to fix cleanly this issue. In the meantime, global pinning can be a nice option. But how to ensure that no other library in conda-forge need the cppad 2024 version ? The last, and maybe the safest option, is to remove cppadcodegen dependency from conda-forge pinocchio package. |
…nda-forge-pinning 2024.05.27.20.59.24
Cool, that is great!
Basically if you add a global pin, you also create a migration and all downstream ports gets rebuilt for that specific cppad version. However, if you already plan to fix this in cppadcodgen, we can wait for the fix, and leave with temporary incompatibility for now.
Even with proxsuite available, there are some fixes necessary in CasADi's CMake to be able to support pypy. I guess they are doable, but I never looked into that as we do not have users using pypy. |
@conda-forge-admin, please restart ci |
Just for alignment/cross-link, I guess the upstream issue is coin-or/CppAD#206 . |
Upstream patch for CppADCodeGen: |
@conda-forge-admin, please restart ci |
@conda-forge-admin, please restart ci |
@conda-forge-admin, please restart ci |
Hello @traversaro, I have some issue with PyPy. When loading the Python binding made with PyPy, the interpreter crash. #include <boost/python.hpp>
struct Toto
{};
char const* greet(int x, const Toto& t)
{
return "hello, world";
}
BOOST_PYTHON_MODULE(test)
{
using namespace boost::python;
class_<Toto>("Toto");
Toto t;
def("greet", greet, (arg("x")=0, arg("t")=t));
} You can build this example with the following command : g++ -I$CONDA_PREFIX/include test.cpp -I$CONDA_PREFIX/include/pypy3.9 -L$CONDA_PREFIX/lib -lboost_python39 --shared -fPIC -o test.pypy39-pp73-x86_64-linux-gnu.so -g And run with the following one : python -c "import test" Unfortunately, I don't get why this code crash with PyPy, but work with CPython.
But it doesn't help so much. I will try to continue the investigation, but in the meantime I wondering if it's possible to deactivate PyPy build for this release ? Thank ! |
For me it is perfectly fine to do not build for |
Perfect, how can I disable the PyPy build ? |
As far as I know the 6 hours limit is enforced by Azure CI, so it is not possible to increase it. The only way to get longer time is to use https://github.com/Quansight/open-gpu-server, but that requires special permissions so I am not sure if it possible to get them in this case, and even if it is possible it will take times, so finding some solution to fix in 6 hours may be the best option at the moment. |
…nda-forge-pinning 2024.06.17.07.15.55
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: disabled
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.
Packages found by source code inspection but not in the meta.yaml:
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/9263225890 - please use this URL for debugging.