Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port TZPATH patch from CPython 3.9 #108

Merged
merged 4 commits into from
Sep 24, 2023
Merged

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Sep 22, 2023

Investigating whether we see conda-forge/backports.zoneinfo-feedstock#16 (comment) directly in CI here.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy
Copy link
Member Author

xhochy commented Sep 22, 2023

Awesome, we can at least replicate it.

@xhochy xhochy changed the title Reproduce zoneinfo bug Port TZPATH patch from CPython 3.9 Sep 23, 2023
@xhochy
Copy link
Member Author

xhochy commented Sep 23, 2023

@conda-forge/pypy3-6 @isuruf This is ready for review&merge.

@isuruf isuruf merged commit bea4b0d into conda-forge:main Sep 24, 2023
@isuruf
Copy link
Member

isuruf commented Sep 24, 2023

Thanks

@mattip
Copy link
Contributor

mattip commented Sep 24, 2023

I reopened the PyPy issue around this. Is is conda-specific or should PyPy be doing something different on windows? https://foss.heptapod.net/pypy/pypy/-/issues/3653

@mattip
Copy link
Contributor

mattip commented Sep 24, 2023

@xhochy xhochy deleted the zoneinfo-bug branch September 25, 2023 19:18
@xhochy
Copy link
Member Author

xhochy commented Sep 25, 2023

The bug was introduced in PyPy once PyPy synced the respective module from CPython. Thus having the same patch on both sides is the most logical path.

@mattip mattip mentioned this pull request Sep 29, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants