-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port TZPATH patch from CPython 3.9 #108
Conversation
…nda-forge-pinning 2023.09.22.05.46.25
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Awesome, we can at least replicate it. |
@conda-forge/pypy3-6 @isuruf This is ready for review&merge. |
Thanks |
I reopened the PyPy issue around this. Is is conda-specific or should PyPy be doing something different on windows? https://foss.heptapod.net/pypy/pypy/-/issues/3653 |
Ahh, I see CPython has a similar patch https://github.com/conda-forge/python-feedstock/blob/main/recipe/patches/0010-Fix-TZPATH-on-windows.patch |
The bug was introduced in PyPy once PyPy synced the respective module from CPython. Thus having the same patch on both sides is the most logical path. |
Investigating whether we see conda-forge/backports.zoneinfo-feedstock#16 (comment) directly in CI here.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)