Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7.3.13 #110

Merged
merged 4 commits into from
Sep 30, 2023
Merged

V7.3.13 #110

merged 4 commits into from
Sep 30, 2023

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Sep 29, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.
  • Update to pypy7.3.13 for python3.9, drop building python3.8 (since it is no longer getting updates)
  • remove patches and build script segments for python3.8 and for updates after 7.3.12

Fixes #109 (tested by creating an environment with 7.3.12, installing pandas, reproducing the failure. Then substituting the libpypy3.9-c.so with the one from this build and checking that the failure is gone).

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mattip
Copy link
Contributor Author

mattip commented Sep 29, 2023

Windows is failing with

ModuleNotFoundError: No module named 'tzdata'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\bld\pypy3.9_1695978865364\_test_env\Lib\zoneinfo\_zoneinfo.py", line 43, in __new__
    instance = cls._weak_cache.setdefault(key, cls._new_instance(key))
  File "D:\bld\pypy3.9_1695978865364\_test_env\Lib\zoneinfo\_zoneinfo.py", line 70, in _new_instance
    file_obj = _common.load_tzdata(key)
  File "D:\bld\pypy3.9_1695978865364\_test_env\Lib\zoneinfo\_common.py", line 24, in load_tzdata
    raise ZoneInfoNotFoundError(f"No time zone found with key {key}")
zoneinfo._common.ZoneInfoNotFoundError: 'No time zone found with key America/Los_Angeles'

It was similarly failing in #108. Is this something that should be skipped on windows?

@mattip
Copy link
Contributor Author

mattip commented Sep 29, 2023

Ahh, I removed too much from meta.yaml

@mattip
Copy link
Contributor Author

mattip commented Sep 29, 2023

Note to self: merging this will require an additional PR to https://github.com/conda-forge/pypy-meta-feedstock for 7.3.13, like conda-forge/pypy-meta-feedstock#30

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, happy to see this being fixed!

@h-vetinari
Copy link
Member

merging this will require an additional PR

For completeness: merging here is fine (actually, a prerequisite); the pypy-meta PR is just necessary so that 7.3.13 is generally available.

@mattip mattip merged commit f7a4673 into conda-forge:main Sep 30, 2023
@mattip
Copy link
Contributor Author

mattip commented Sep 30, 2023

Self merging to move this forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with cython-generated code: cython_function_or_method' is not an acceptable base type
2 participants