Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GoodVibes to conda-forge #11349

Closed
wants to merge 10 commits into from
Closed

Adding GoodVibes to conda-forge #11349

wants to merge 10 commits into from

Conversation

luchini18
Copy link
Contributor

@luchini18 luchini18 commented Apr 22, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/GoodVibes) and found it was in an excellent condition.

@bobbypaton
Copy link

just confirming I am a willing maintainer...

recipes/example/meta.yaml Outdated Show resolved Hide resolved
recipes/GoodVibes/meta.yaml Show resolved Hide resolved
recipes/GoodVibes/meta.yaml Outdated Show resolved Hide resolved
@synapticarbors
Copy link
Member

@conda-forge/staged-recipes -- It looks like this is failing due to a bug in conda-build that was patched ~20 days ago:

conda/conda-build@bb8b53f

It looks like it's in the 3.19.3 release. Any idea of when we will be updating?

@chrisburr
Copy link
Member

@luchini18
Copy link
Contributor Author

Just to clarify, are we holding off until this issue is resolved?

@synapticarbors
Copy link
Member

I think we need to, unfortunately, but maybe another more experienced reviewer might know more.

@chrisburr
Copy link
Member

If this is blocking something important you could try downgrading conda-build to an older version by editing this line to check the CI works. The change should be reverted before this is merged and the feedstock build will then fail but you can apply a similar hack in the feedstock after it's created.

@stale
Copy link

stale bot commented Sep 20, 2020

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Sep 20, 2020
@stale
Copy link

stale bot commented Oct 20, 2020

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

5 participants