Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-build v3.19.3 #134

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://circleci.com/gh/regro/circle_worker/15802, please use this URL for debugging

regro-cf-autotick-bot added 2 commits April 13, 2020 22:29
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mbargull
Copy link
Member

Please hold off on merging. This reintroduces a bug: conda/conda-build#3935.

@isuruf
Copy link
Member

isuruf commented May 1, 2020

@mbargull, ping

@mbargull
Copy link
Member

mbargull commented May 1, 2020

No news from my side. I can only refer to the conda-build team. @mingwandroid started work on this in conda/conda-build#3937.

@scopatz
Copy link
Member

scopatz commented May 12, 2020

Should we still hold off on this?

@bgruening
Copy link

It would be nice to get this into a release: https://github.com/conda/conda-build/pull/3925/files

I think this is what is blocking many PRs at the moment.

@bgruening
Copy link

Oh, we have this already. Mh, I need to investigate why PRs still failing.

@saraedum
Copy link
Member

saraedum commented Jun 12, 2020

@bgruening do we already have #3925? It says on the MR that it's in 3.19.3. nevermind, it's in a .patch already.

@jakirkham
Copy link
Member

@bgruening do we already have #3925? It says on the MR that it's in 3.19.3. nevermind, it's in a .patch already.

Actually I'm seeing it in 3.19.3 too. Should we just try this? Worst case we can still pull it 🙂

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render.

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@jakirkham
Copy link
Member

Yeah the patch no longer applies here. Think that means it is already upstream.

@jakirkham
Copy link
Member

The only patch that hasn't been integrated upstream is PR ( conda/conda-build#3606 ).

@jakirkham
Copy link
Member

@bgruening, would you be able to review? 🙂

@mbargull
Copy link
Member

#134 (comment) still stands. conda/conda-build#3952 likely includes the fix. Unless someone is willing to backport the relevant parts, 3.19.3 would create broken shebangs for noarch packages (conda/conda-build#3935).

@beckermr
Copy link
Member

Should we close this as we've shipped a version after this one?

@regro-cf-autotick-bot regro-cf-autotick-bot mentioned this pull request Sep 3, 2020
3 tasks
@isuruf isuruf closed this in #148 Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants