12 3.19.4 bits #3952

mingwandroid · 2020-05-12T21:33:30Z

No description provided.

@mbargull

Sorry about this @mbargull

…plicit-inclusion-only when given as a list

… or dirty are set .. same thing with host prefix. The code and concepts behind --dirty, --keep-old-work and also perhaps build/no_move_top_level_workdir_loops seem a bit muddled and overlapping. --dirty should *only* deal with finding a new croot, and have no part in whether to keep stuff around or not. That should be left to a new option, like: --keep=work,build-prefix,host-prefix,test-prefix,test-tmp where --keep-old-work is deprecated but enables all of these. Also, 'keep' might not be the best word, call it what we do, --retain-via-rename=work,..

…ors from the last command do not exit the interactive shell (very annoying when testing package build failures). We then must 'set -e' just after sourcing the env script.

Reverse failed patches so they do not leave behind newly created files for bits that manged to apply OK (causing subsequent patches to potentially fail). Rewrite apply_patch to behave more sanely, esp. in the face of fully-correct, binary patches. .. also, try the same patch modifications we try on Windows on the other OSes. There is no reason not to.

These files are left behind by macOS when it needs to ratain its extended attributes through round-trips to 'foreign' file-systems. And do we need two different bits of code globbing for meta.yamls? No, we do not.

Changes :: Uses lief 0.10.1 now (no code changes were needed for this update) Fixes _map_file_to_package for finding '.dylib' and '.so' without suffixes beyond that Added our FakeDist to run-prefix, improve library_nature, do not fail if ccache exists Fixes detection of where packages comes from. We must avoid using 'canonical' channel names (such as 'default', needing instead 'pkgs/main') when determining which channels packages come from. To do this, we use a new function, linked_data_no_multichannels(). Let's hope we never end up comparing these with ones gotten via linked_data() Add local_output_folder to get_build_index()'s locally cached things. Ensure we pass 'channel_urls' as a list and add the 'local' channel to that. Disambiguate 'prefix' DSO files in the build/host throughout ovelink detection. Change ERROR :: {} not in prefix_owners to a more helpful warning and add a comment though it might be better to just remove this warning and let the final info detail any issues (for they will show up as overlinking errors). Notes :: This is still not the speed boost that this stuff needs, so I am hoping the update to 0.10.1 helps with that. Looking at the history, it should, somewhat. Case-insensitive lookup for Windows (hopefully only for files in the sysroot - which is being referred to as the whitelist in the messages ATM unfortunately - still remains to be done (and will probably get squashed into this commit).

mingwandroid · 2020-05-12T21:34:31Z

@jjhelmus preview, I will also check some community PRs once you (and ci) are happy with all this!

cla-bot · 2020-05-13T12:21:34Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: distro-bot@anaconda.com.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

conda_build/build.py

cla-bot · 2020-05-14T12:25:38Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: distro-bot@anaconda.com.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

.. New link location: None for example

too liberal and we may want to do it only for Windows exes/dlls.

cla-bot · 2020-05-14T14:03:37Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: distro-bot@anaconda.com.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

…ix_files

…lease The downside is that some packages may not get picked up. I need to check that though. It cannot remain this broken. The problem seems to be that depending on how the channel was identified to conda when it made the Dist is how it will remain and one created from 'defaults' is not equal to one created from 'pkgs/main'. During conda-build post, our channels seem to come from 'pkgs/main' but at other times they come from 'defaults'.

mingwandroid · 2020-05-14T18:55:37Z

I think this is good to go now. If you have time and agree, I'll look over community PRs after some food.

github-actions · 2022-03-11T06:06:20Z

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

mingwandroid added 14 commits May 12, 2020 23:25

Default for build/detect_binary_files_with_prefix should be True

427146e

Test fix for latest prefix replacement trouble

613a4c2

Sorry about this @mbargull

Bye bye macOS-10.13, why can we not test on old OSes?

51f454c

Fix Miniconda3 URL for macOS AP testing

dcb17e3

Update test_recipe_builds[has_prefix_files] as has_prefix_files is ex…

295fc8b

…plicit-inclusion-only when given as a list

And fix the binary one again

1a9ae0f

Fix entry_points_have_prefix_noarch_has_prefix_files on Windows

fe7b221

jsonify any files in RECIPE_DIR/info_yaml.d

5c3cf7e

At the end of the env activation script, use 'set +e' so that any err…

51658d0

…ors from the last command do not exit the interactive shell (very annoying when testing package build failures). We then must 'set -e' just after sourcing the env script.

macho thing, otool

237b0d4

Filter out '/.AppleDouble' folders from find_recipe

f4b2a13

These files are left behind by macOS when it needs to ratain its extended attributes through round-trips to 'foreign' file-systems. And do we need two different bits of code globbing for meta.yamls? No, we do not.

cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label May 12, 2020

cla-bot bot removed the cla-signed [bot] added once the contributor has signed the CLA label May 13, 2020

jjhelmus reviewed May 13, 2020

View reviewed changes

conda_build/build.py Show resolved Hide resolved

mingwandroid added 2 commits May 14, 2020 14:30

Tidy up a lot of messages

8d7fd18

.. New link location: None for example

Look for filename matches case insensitively in post. This may be

5cb5d01

too liberal and we may want to do it only for Windows exes/dlls.

mingwandroid force-pushed the 12-3.19.4-bits branch from 1ed181d to 5cb5d01 Compare May 14, 2020 12:30

cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label May 14, 2020

pep8

c54d75c

cla-bot bot removed the cla-signed [bot] added once the contributor has signed the CLA label May 14, 2020

ensure_list() does not, it ensures __iter__

119e434

mingwandroid force-pushed the 12-3.19.4-bits branch from 2b4aa0c to 119e434 Compare May 14, 2020 14:05

cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label May 14, 2020

mingwandroid added 4 commits May 14, 2020 17:55

Add missing test file fixing entry_points_have_prefix_noarch_has_pref…

ba70dee

…ix_files

pep8

4a23f1b

Skip test involving sympy on python 2.7 (let the rot commence)

c06b6b5

mingwandroid merged commit ba6cf7a into conda:master May 14, 2020

mbargull mentioned this pull request Jun 25, 2020

conda-build v3.19.3 conda-forge/conda-build-feedstock#134

Closed

3 tasks

wilsonmr mentioned this pull request Sep 10, 2020

New version of conda-build throws error if channel URL path is conda NNPDF/nnpdf#915

Closed

github-actions bot added the locked [bot] locked due to inactivity label Mar 11, 2022

github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

12 3.19.4 bits #3952

12 3.19.4 bits #3952

mingwandroid commented May 12, 2020

mingwandroid commented May 12, 2020

cla-bot bot commented May 13, 2020

cla-bot bot commented May 14, 2020

cla-bot bot commented May 14, 2020

mingwandroid commented May 14, 2020

github-actions bot commented Mar 11, 2022

12 3.19.4 bits #3952

12 3.19.4 bits #3952

Conversation

mingwandroid commented May 12, 2020

mingwandroid commented May 12, 2020

cla-bot bot commented May 13, 2020

cla-bot bot commented May 14, 2020

cla-bot bot commented May 14, 2020

mingwandroid commented May 14, 2020

github-actions bot commented Mar 11, 2022