Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variants: remove hard-coded default path for CONDA_BUILD_SYSROOT #3606

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

mbargull
Copy link
Member

In 8a32641#diff-593f4997b372b8d4a4fe630de1e497adR36 a hard-coded path was added as a default value for CONDA_BUILD_SYSROOT.
The commit message from that commit is

Set CONDA_BUILD_SYSROOT during tests to /opt/MacOSX10.10.sdk

. So, supposedly, this also wasn't meant to be added as a general default value, but just for tests.
If it is still needed to be set for some tests, feel free to add it to the appropriate place and commit to this branch (meaning, "Allow edits from maintainers." is enabled).

@msarahan
Copy link
Contributor

Yeah, I think the reason why it was added there in particular is that we don't have a separate collection of variants for tests. We need to add that, probably before merging this PR.

@jakirkham
Copy link
Member

Is this still needed @mbargull? If so, what are the next steps here?

@mbargull
Copy link
Member Author

Is this still needed @mbargull?

Yep.

If so, what are the next steps here?

Merge pull request ;)

@jakirkham
Copy link
Member

Thoughts @mingwandroid?

@mingwandroid
Copy link
Contributor

Thanks @mbargull and @jakirkham

@isuruf
Copy link
Contributor

isuruf commented Aug 31, 2020

Ping on this. We still carry this patch in conda-forge.

@mingwandroid mingwandroid merged commit 34e1e78 into conda:master Aug 31, 2020
@mingwandroid
Copy link
Contributor

We'll hopefully do a quick mop-up release for CB 3.20.0. I've seen nothing too serious so far, just one thing. Sometimes on very big package builds, Windows file locking prevents a shutil.move operation from working reliably. I fixed the same thing during the build phase and while I'm not 100% happy with the fix, it's better than a failing build.

@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants