-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add package jupyterlab-language-pack-ar-SA #15771
PR: Add package jupyterlab-language-pack-ar-SA #15771
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/jupyterlab-language-pack-ar-SA:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@blink1073, @fcollonval, @krassowski do you agree to be added as maintainers? Thanks! |
👍🏼 |
+1 to all language packs |
I agree |
As upstream is onboard here: Wouldn't it be easier to tag a release in the upstream repo and the package that (instead of the individual files from pypi) via a one single multi-output/jinja2-equiped recipe/feedstock into individual conda packages? All those language packs seem to be pretty much similar regarding dependencies and other meta-data and updating once recipe over time should be easier compared to keep multiple of those in sync. Just thinking... or is there anything preventing that? |
Will try that @dbast Thanks for the suggestion! |
At @dbast, thanks for the suggestion. I have one question regarding the multi-packages approach. Is the bot able to update the recipe if only one source on Pypi gets updated? |
@fcollonval One source definition + multiple outputs recipes are bot-auto-updatable ... that can e.g. be seen here https://github.com/conda-forge/airflow-feedstock/blob/master/recipe/meta.yaml ... and the previous merged PRs: https://github.com/conda-forge/airflow-feedstock/pulls?q=is%3Apr+is%3Aclosed |
Thanks for the info @dbast just checking, so a single release tag (on github) on the single source would trigger the bot? |
yes. that is my understanding. Additional to that airflow multi output recipe a jinja2 loop could be potentially used to generate all outputs dynamically based on the 27 languages. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).