Skip to content

Add jupyter language multi packs recipe #15969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 23, 2021

Conversation

fcollonval
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

This is based on #15771 (comment)

Closes #15771
Closes #15776
Closes #15777
Closes #15778
Closes #15779
Closes #15780
Closes #15781
Closes #15782
Closes #15783
Closes #15784
Closes #15785
Closes #15786
Closes #15787
Closes #15788
Closes #15789
Closes #15790
Closes #15791
Closes #15792
Closes #15793
Closes #15794
Closes #15795
Closes #15796
Closes #15797
Closes #15798
Closes #15799
Closes #15800
Closes #15801

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/juypterlab-language-packs) and found some lint.

Here's what I've got...

For recipes/juypterlab-language-packs:

  • The recipe must have some tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/juypterlab-language-packs) and found some lint.

Here's what I've got...

For recipes/juypterlab-language-packs:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'outputs', 'about', 'extra'].

@fcollonval fcollonval force-pushed the ft/add-jlab-language branch from 4a617d0 to de408a5 Compare August 21, 2021 10:42
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/juypterlab-language-packs) and found it was in an excellent condition.

@fcollonval fcollonval changed the title Add jupyter language multi packs recipe WIP Add jupyter language multi packs recipe Aug 21, 2021
@fcollonval fcollonval marked this pull request as ready for review August 21, 2021 10:43
@fcollonval fcollonval closed this Aug 21, 2021
@fcollonval fcollonval reopened this Aug 21, 2021
@fcollonval fcollonval marked this pull request as draft August 21, 2021 10:45
@fcollonval fcollonval changed the title WIP Add jupyter language multi packs recipe Add jupyter language multi packs recipe Aug 21, 2021
@fcollonval
Copy link
Contributor Author

fcollonval commented Aug 21, 2021

@fcollonval
Copy link
Contributor Author

fcollonval commented Aug 22, 2021

This change the conda packaging of JupyterLab language packs in a mono-recipe.

@blink1073 @goanpeca @krassowski do you agree to become maintainers of this recipe?

@fcollonval fcollonval marked this pull request as ready for review August 22, 2021 09:02
@fcollonval
Copy link
Contributor Author

@blink1073
Copy link
Member

👍🏼

@krassowski
Copy link
Contributor

I agree.

Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@xhochy xhochy merged commit 8f079c4 into conda-forge:master Aug 23, 2021
@blink1073
Copy link
Member

Thanks @fcollonval and @xhochy!

@fcollonval fcollonval deleted the ft/add-jlab-language branch August 23, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants