Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmeutils #18608

Merged
merged 6 commits into from
Apr 8, 2022
Merged

Add cmeutils #18608

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
56db384
Update meta yaml for cmeutils
jennyfothergill Apr 6, 2022
27f2761
Update license name
jennyfothergill Apr 6, 2022
6e12078
Add cython
jennyfothergill Apr 6, 2022
21c18c3
Remove Eric
jennyfothergill Apr 6, 2022
9a41997
Remove pip
jennyfothergill Apr 7, 2022
39363c0
Remove cython and pip check test
jennyfothergill Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions recipes/cmeutils/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{% set name = "cmeutils" %}
{% set version = "0.0.1" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://github.com/cmelab/cmeutils/archive/refs/tags/v{{ version }}.tar.gz
sha256: bc8ba46d485e35d45f9d0e719a139afaaacf534ae44e55c1ca1f7ac314671067

build:
noarch: python
script: {{ PYTHON }} -m pip install . -vv
number: 0

requirements:
host:
- python >=3.6
- pip
run:
- python >=3.6
- cython
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is cython required? I don't see it in the source code. Also it seems like pip shouldn't be a run time requirement either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cython is not required, but the build for 27f2761 was failing because freud was not pulling cython. I will make an issue on freud and remove pip.

Copy link
Contributor

@bdice bdice Apr 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be safe to remove cython from the runtime requirements of this package.

Cython was mistakenly listed in install_requires for freud, meaning that pip check was searching for Cython as a runtime requirement. It is only a build-time requirement, which is correctly listed in the freud feedstock but not in freud's setup.py. This caused pip check to fail. This PR will fix the upstream for freud's next release: glotzerlab/freud#938 In the meantime, I would skip the pip check test. Thank you for the bug discovery!

- freud
- gsd
- numpy
- pip
- matplotlib-base
- pymbar
- rowan

test:
imports:
- cmeutils
requires:
- pip
commands:
- pip check

about:
home: https://github.com/cmelab/cmeutils
summary: 'Useful functions by and for the CME lab.'
description: |
Helpful functions used by the CME Lab.
license: GPL-3.0-or-later
license_family: GPL
license_file: LICENSE
doc_url: https://github.com/cmelab/cmeutils
dev_url: https://github.com/cmelab/cmeutils

extra:
recipe-maintainers:
- jennyfothergill
- chrisjonesBSU