-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmeutils #18608
Add cmeutils #18608
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/cmeutils:
Documentation on acceptable licenses can be found here. |
@chrisjonesBSU @erjank comment here if you're OK with being a maintainer for cmeutils on conda-forge |
I am Ok with being a maintainer for cmeutils on coda-forge |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
can add him later if he wants
@conda-forge/staged-recipes this PR is ready for review |
recipes/cmeutils/meta.yaml
Outdated
- pip | ||
run: | ||
- python >=3.6 | ||
- cython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is cython
required? I don't see it in the source code. Also it seems like pip
shouldn't be a run time requirement either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cython
is not required, but the build for 27f2761 was failing because freud
was not pulling cython
. I will make an issue on freud
and remove pip
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be safe to remove cython
from the runtime requirements of this package.
Cython was mistakenly listed in install_requires
for freud, meaning that pip check
was searching for Cython as a runtime requirement. It is only a build-time requirement, which is correctly listed in the freud feedstock but not in freud's setup.py
. This caused pip check
to fail. This PR will fix the upstream for freud's next release: glotzerlab/freud#938 In the meantime, I would skip the pip check
test. Thank you for the bug discovery!
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).