Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmeutils #18608

Merged
merged 6 commits into from
Apr 8, 2022
Merged

Add cmeutils #18608

merged 6 commits into from
Apr 8, 2022

Conversation

jennyfothergill
Copy link
Contributor

@jennyfothergill jennyfothergill commented Apr 6, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cmeutils) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/cmeutils:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@jennyfothergill
Copy link
Contributor Author

@chrisjonesBSU @erjank comment here if you're OK with being a maintainer for cmeutils on conda-forge

@chrisjonesBSU
Copy link
Contributor

@chrisjonesBSU @erjank comment here if you're OK with being a maintainer for cmeutils on conda-forge

I am Ok with being a maintainer for cmeutils on coda-forge

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cmeutils) and found it was in an excellent condition.

can add him later if he wants
@jennyfothergill
Copy link
Contributor Author

@conda-forge/staged-recipes this PR is ready for review

- pip
run:
- python >=3.6
- cython
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is cython required? I don't see it in the source code. Also it seems like pip shouldn't be a run time requirement either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cython is not required, but the build for 27f2761 was failing because freud was not pulling cython. I will make an issue on freud and remove pip.

Copy link
Contributor

@bdice bdice Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be safe to remove cython from the runtime requirements of this package.

Cython was mistakenly listed in install_requires for freud, meaning that pip check was searching for Cython as a runtime requirement. It is only a build-time requirement, which is correctly listed in the freud feedstock but not in freud's setup.py. This caused pip check to fail. This PR will fix the upstream for freud's next release: glotzerlab/freud#938 In the meantime, I would skip the pip check test. Thank you for the bug discovery!

@synapticarbors synapticarbors merged commit 2f1ef78 into conda-forge:main Apr 8, 2022
@jennyfothergill jennyfothergill deleted the add/cmeutils branch April 8, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants