Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craftr #2189

Merged
merged 9 commits into from
Feb 2, 2017
Merged

Craftr #2189

merged 9 commits into from
Feb 2, 2017

Conversation

dfroger
Copy link
Contributor

@dfroger dfroger commented Jan 10, 2017

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/craftr) and found it was in an excellent condition.

@dfroger
Copy link
Contributor Author

dfroger commented Jan 12, 2017

  • fix the traceback:
Fixing permissions
Fixing permissions
Detected hard-coded path in text file bin/craftr
'lib/python3.4/site-packages/craftr/stl/craftr.utils.git/Craftrfile' not in tarball
'lib/python3.4/site-packages/craftr/stl/craftr.utils.git/manifest.json' not in tarball
Traceback (most recent call last):
  File "/opt/conda/bin/conda-build-all", line 6, in <module>
    sys.exit(conda_build_all.cli.main())
  File "/opt/conda/lib/python3.5/site-packages/conda_build_all/cli.py", line 90, in main
    b.main()
  File "/opt/conda/lib/python3.5/site-packages/conda_build_all/builder.py", line 267, in main
    built_dist_location = self.build(meta, build_config)
  File "/opt/conda/lib/python3.5/site-packages/conda_build_all/builder.py", line 204, in build
    conda_build.api.build(meta.meta, config=config)
  File "/opt/conda/lib/python3.5/site-packages/conda_build/api.py", line 86, in build
    need_source_download=need_source_download, config=config)
  File "/opt/conda/lib/python3.5/site-packages/conda_build/build.py", line 1427, in build_tree
    config=config)
  File "/opt/conda/lib/python3.5/site-packages/conda_build/build.py", line 1103, in build
    built_package = bundlers[output.get('type', 'conda')](output, m, config, env)
  File "/opt/conda/lib/python3.5/site-packages/conda_build/build.py", line 840, in bundle_conda
    tarcheck.check_all(tmp_path)
  File "/opt/conda/lib/python3.5/site-packages/conda_build/tarcheck.py", line 90, in check_all
    x.info_files()
  File "/opt/conda/lib/python3.5/site-packages/conda_build/tarcheck.py", line 55, in info_files
    raise Exception('info/files')
Exception: info/files
  • some build requirements must be removed : there are only run requirements.

@dfroger
Copy link
Contributor Author

dfroger commented Jan 17, 2017

I'm waiting for conda/conda-build#1657 which fix the above exception.

@dfroger
Copy link
Contributor Author

dfroger commented Jan 24, 2017

close and reopen to test with conda-build 2.1.2

@dfroger dfroger closed this Jan 24, 2017
@dfroger dfroger reopened this Jan 24, 2017
@dfroger
Copy link
Contributor Author

dfroger commented Jan 25, 2017

After removing some build requriements, i get erros that I don't understand:

Traceback (most recent call last):
  File "/opt/conda/lib/python3.5/site-packages/conda_build/build.py", line 676, in create_env
    actions = plan.install_actions(prefix, index, specs)
  File "/opt/conda/lib/python3.5/site-packages/conda/plan.py", line 484, in install_actions
    pkgs = r.install(specs, installed, update_deps=update_deps)
  File "/opt/conda/lib/python3.5/site-packages/conda/resolve.py", line 871, in install
    pkgs = self.solve(specs, returnall=returnall)
  File "/opt/conda/lib/python3.5/site-packages/conda/resolve.py", line 908, in solve
    dists, new_specs = self.get_dists(specs)
  File "/opt/conda/lib/python3.5/site-packages/conda/resolve.py", line 517, in get_dists
    raise UnsatisfiableError(save_unsat)
conda.exceptions.UnsatisfiableError: The following specifications were found to be in conflict:
  - craftr 2.0.0.dev5 py36_0
  - python 3.6*
Use "conda info <package>" to see the dependencies for each package.

@dfroger
Copy link
Contributor Author

dfroger commented Jan 25, 2017

Maybe just some dependencies that are not yet built for python 3.6

@dfroger
Copy link
Contributor Author

dfroger commented Jan 27, 2017

For me, it's ready to be merged!

@jjhelmus
Copy link
Contributor

jjhelmus commented Feb 2, 2017

LGTM, thanks @dfroger

@jjhelmus jjhelmus merged commit 1338ea4 into conda-forge:master Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants