Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directories like xxx.git are removed from tarball #1655

Closed
dfroger opened this issue Jan 13, 2017 · 3 comments · Fixed by #1657
Closed

directories like xxx.git are removed from tarball #1655

dfroger opened this issue Jan 13, 2017 · 3 comments · Fixed by #1657
Labels
locked [bot] locked due to inactivity
Milestone
2.1.2

Comments

@dfroger
Copy link
Contributor

dfroger commented Jan 13, 2017 •
edited
Loading

I'm trying to build a conda package for craftr, which contains a directory craftr/stl/craftr.utils.git/ that is filtered out from the tarball during build. The problem is then detected in tarcheck.py. See conda-forge/staged-recipes#2189

I think it comes from the filter_files function.

I'm working on a PR.
@msarahan
Copy link
Contributor

Thanks. Naive of me to think that filter files would always work...

Looking forward to the PR.

@msarahan msarahan added this to the 2.1.2 milestone Jan 13, 2017
dfroger added a commit to dfroger/conda-build that referenced this issue Jan 13, 2017
@dfroger
filter .git directories, but not x.git ones
c32fa1b 
This fix conda#1655
@dfroger dfroger mentioned this issue Jan 13, 2017
Merged
@dfroger
Copy link
Contributor Author

dfroger commented Jan 13, 2017

The cool thing is that filter_files already has unit tests :)

dfroger added a commit to dfroger/conda-build that referenced this issue Jan 13, 2017
@dfroger
filter .git directories, but not x.git ones
ac530ac 
This fix conda#1655
@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically locked because it has not had recent activity after being closed.

Please open a new issue if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked [bot] locked due to inactivity
Projects
None yet
Milestone
2.1.2
Development

Successfully merging a pull request may close this issue.

filter .git directories, but not x.git ones dfroger/conda-build
2 participants
@msarahan @dfroger