Mayavi #2215

dfroger · 2017-01-15T20:06:00Z

others mayavi PR: #285, #1581, #2014

This PR disable osx and win for now.

It should works on GNU/Linux

conda-forge-linter · 2017-01-15T20:06:06Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mayavi) and found it was in an excellent condition.

dfroger · 2017-01-15T20:57:52Z

Error on Gnu/Linux:

setup.py: cannot connect to X server 
Traceback (most recent call last):
  File "/opt/conda/bin/conda-build-all", line 11, in <module>
    load_entry_point('conda-build-all==1.0.0', 'console_scripts', 'conda-build-all')()
  File "/opt/conda/lib/python3.5/site-packages/conda_build_all/cli.py", line 90, in main
    b.main()
  File "/opt/conda/lib/python3.5/site-packages/conda_build_all/builder.py", line 263, in main
    built_dist_location = self.build(meta, build_config)
  File "/opt/conda/lib/python3.5/site-packages/conda_build_all/builder.py", line 200, in build
    conda_build.api.build(meta.meta, config=config)
  File "/opt/conda/lib/python3.5/site-packages/conda_build/api.py", line 89, in build
    need_source_download=need_source_download, config=config)
  File "/opt/conda/lib/python3.5/site-packages/conda_build/build.py", line 1460, in build_tree
    config=config)
  File "/opt/conda/lib/python3.5/site-packages/conda_build/build.py", line 1043, in build
    utils.check_call_env(cmd, env=env, cwd=src_dir)
  File "/opt/conda/lib/python3.5/site-packages/conda_build/utils.py", line 590, in check_call_env
    return _func_defaulting_env_to_os_environ(subprocess.check_call, *popenargs, **kwargs)
  File "/opt/conda/lib/python3.5/site-packages/conda_build/utils.py", line 586, in _func_defaulting_env_to_os_environ
    return func(_args, **kwargs)
  File "/opt/conda/lib/python3.5/subprocess.py", line 581, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/bin/bash', '-x', '-e', '/staged-recipes/build_artefacts/mayavi_1484511111763/work/conda_build.sh']' returned non-zero exit status 1

./scripts/run_docker_build.sh returned exit code 1

qtconsole has a similar issue, and solve it with xvfb.

dfroger · 2017-01-15T21:10:09Z

xvfb is also recommand in mayavi doc, will try this solution

dfroger · 2017-01-16T19:40:15Z

There may be still adjustements/improvements to do, but the recipe as it is works for GNU/Linux.

@hadim @grlee77 @Cadair @ocefpaf If you are ok, we can merge this mayavi recipe for GNU/Linux, and then tackle Windows and OSX build?

ocefpaf · 2017-01-16T19:43:37Z

recipes/mayavi/meta.yaml

+
+about:
+  home: https://github.com/enthought/mayavi
+  license: BSD


Do you know if this is BSD 2-Clause or BSD 3-Clause?

ocefpaf · 2017-01-16T19:53:41Z

recipes/mayavi/meta.yaml

+    - apptools
+    - envisage
+    - pyqt
+    - setuptools


Does mayavi needs pkg_resources? If not we can remove setuptools from the run dependencies.

seems that yes, pkg_resources is needed

ocefpaf · 2017-01-16T19:54:16Z

recipes/mayavi/meta.yaml

+  build:
+    - toolchain
+    - python
+    - numpy


Do you know if mayavi relies on numpy ABI? If so we need to use numpy x.x here and below.

yes it does.

files tvtk/src/array_ext.c and tvtk/src/array_ext.pyx calls Numpy C-API, does it means it relies on numpy ABI?

By the way, seems that mayavi and tvtk could be in two differents packages.

Yeah, You do need to add numpy x.x then.

By the way, seems that mayavi and tvtk could be in two differents packages.

Maybe you could test the new conda-build feature that creates multiple packages from a single recipe. (But I would not try that now. I would get this merged first ;-)

The doc says: "TVTK is meant to be installed as part of the mayavi package.", so it must be ok to have 1 package

I changed to numpy x.x

ocefpaf · 2017-01-16T19:54:45Z

@dfroger why the change in .CI/build_all 100755 → 100644 ?

ocefpaf · 2017-01-16T20:00:47Z

recipes/mayavi/meta.yaml

+
+source:
+  git_url: https://github.com/enthought/mayavi.git
+  git_rev: {{ version }}


Please change this to:

fn: mayavi-{{ version }}.tar.gz url: https://github.com/enthought/mayavi/archive/{{ version }}.tar.gz sha256: 36f688b3ea542e9f8cc0d7faa25e1425723cd00acc8aa640169029f33679ab85

ocefpaf · 2017-01-16T20:01:47Z

recipes/mayavi/meta.yaml

+  entry_points:
+    - mayavi2 = mayavi.scripts.mayavi2:main
+    - tvtk_doc = tvtk.tools.tvtk_doc:main
+  skip: True  # [osx or (linux and py34) or win]


Just curious but why are you skipping PY34? (It does not matter as conda-forge is no longer building packages for Python 3.4)

just because its VTK dependency is skipped for linux and py34, I'll add a comment about that

or should I just remove the py34 skip, as conda-forge no longer build for 3.4?

In that case just remove the skip. It will skip in conda-forge anyways, since we are not building Python 3.4, but users will still be able to build it elsewhere if they want to.

I removed the py34 skip

dfroger · 2017-01-16T20:05:17Z

The file permission change seems to be an error, I'll restaure it

ocefpaf · 2017-01-16T20:41:23Z

recipes/mayavi/meta.yaml

@@ -49,6 +49,8 @@ about:
  license_family: BSD
  license_file: LICENSE.txt
  summary: The Mayavi scientific data 3-dimensional visualizers
+  doc_url: http://docs.enthought.com/mayavi/mayavi
+  dev_url: https://github.com/simplejson/simplejson


Oops. Copy-n-pasta 😉

oops... I fixed dev_url to github (same as home page)

ocefpaf · 2017-01-16T21:58:44Z

Thanks @dfroger! Good luck with the Windows and OS X builds.

jakirkham · 2017-01-17T02:45:14Z

recipes/mayavi/meta.yaml

+    - python
+    - numpy x.x
+    - setuptools
+    - vtk


Should this have been pinned too?

python : 2.7 and 3.5 are supported

vtk: I think yes, we shoud pin it to >= 7.1

jakirkham · 2017-01-17T02:45:29Z

recipes/mayavi/meta.yaml

+  run:
+    - python
+    - numpy x.x
+    - vtk  ==7.1.0


Does it need to be pinned exactly?

I think >= 7.1 is enough. I'll propose the change

Created conda-forge/mayavi-feedstock#1 to not forget

hadim and others added 3 commits January 15, 2017 21:05

Add mayavi recipe

f49ba52

add yum requirements

cffff7b

skip build on osx and win

82842eb

dfroger mentioned this pull request Jan 15, 2017

Add mayavi recipe #2014

Closed

try to skip osx build

532ad09

dfroger added 2 commits January 15, 2017 22:21

add toolchain build requirement

31dc08f

use xvfb

d0a2cc3

ocefpaf reviewed Jan 16, 2017

View reviewed changes

license is BSD-3-Clause

406bbac

ocefpaf reviewed Jan 16, 2017

View reviewed changes

dfroger added 4 commits January 16, 2017 21:08

restaure file permissions

5ba88cb

fix source url

1804233

conda no longer build package for Python 3.4

b538524

mayavi relies on numpy ABI

0c60fa2

ocefpaf reviewed Jan 16, 2017

View reviewed changes

dfroger added 2 commits January 16, 2017 21:42

add doc and dev URL

30e12bf

fix dev url

f6cd411

ocefpaf merged commit 5bdc584 into conda-forge:master Jan 16, 2017

jakirkham reviewed Jan 17, 2017

View reviewed changes

dfroger mentioned this pull request Jan 17, 2017

add mayavi #1581

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mayavi #2215

Mayavi #2215

dfroger commented Jan 15, 2017

conda-forge-linter commented Jan 15, 2017

dfroger commented Jan 15, 2017

dfroger commented Jan 15, 2017

dfroger commented Jan 16, 2017 •

edited

Loading

ocefpaf Jan 16, 2017

dfroger Jan 16, 2017

ocefpaf Jan 16, 2017

dfroger Jan 16, 2017

ocefpaf Jan 16, 2017

Cadair Jan 16, 2017

dfroger Jan 16, 2017

ocefpaf Jan 16, 2017

dfroger Jan 16, 2017

dfroger Jan 16, 2017

ocefpaf commented Jan 16, 2017

ocefpaf Jan 16, 2017

dfroger Jan 16, 2017

ocefpaf Jan 16, 2017

dfroger Jan 16, 2017 •

edited

Loading

dfroger Jan 16, 2017 •

edited

Loading

ocefpaf Jan 16, 2017

dfroger Jan 16, 2017

dfroger commented Jan 16, 2017

ocefpaf Jan 16, 2017

dfroger Jan 16, 2017

ocefpaf commented Jan 16, 2017

jakirkham Jan 17, 2017

dfroger Jan 17, 2017

jakirkham Jan 17, 2017

dfroger Jan 17, 2017

dfroger Jan 17, 2017

Mayavi #2215

Mayavi #2215

Conversation

dfroger commented Jan 15, 2017

conda-forge-linter commented Jan 15, 2017

dfroger commented Jan 15, 2017

dfroger commented Jan 15, 2017

dfroger commented Jan 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocefpaf commented Jan 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dfroger Jan 16, 2017 • edited Loading

Choose a reason for hiding this comment

dfroger Jan 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dfroger commented Jan 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocefpaf commented Jan 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dfroger commented Jan 16, 2017 •

edited

Loading

dfroger Jan 16, 2017 •

edited

Loading

dfroger Jan 16, 2017 •

edited

Loading