Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mayavi recipe #2014

Closed
wants to merge 1 commit into from
Closed

Add mayavi recipe #2014

wants to merge 1 commit into from

Conversation

hadim
Copy link
Member

@hadim hadim commented Nov 27, 2016

A revival of #1581

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mayavi) and found some lint.

Here's what I've got...

For recipes/mayavi:

  • The recipe must have a build/number section.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mayavi) and found it was in an excellent condition.

@hadim
Copy link
Member Author

hadim commented Nov 27, 2016

Waiting for an answer there enthought/mayavi#457

@grlee77
Copy link
Member

grlee77 commented Nov 28, 2016

Hi @hadim. If you have time to take this over from #1581 that is fine by me. One reason aside from lack of time that I have not updated #1581, was that I forgot that VTK was not being built on all platforms due to time limits at the free CI services. For example, the VTK feedstock does not build any OS X packages (or a python 3.4 package on linux).

https://github.com/conda-forge/vtk-feedstock/blob/bb1903e93ba81a7d55aa84879033463a31e3a0c0/recipe/meta.yaml#L19

The same skip line from the VTK recipe will need to be present in the mayavi recipe.

@hadim
Copy link
Member Author

hadim commented Nov 28, 2016

Well I thought the issue was easier to fix than it is.

Maybe we should both keep our PRs open and wait for help or more time to fix it.

@Cadair
Copy link
Member

Cadair commented Jan 14, 2017

can someone restart this build seeing how conda-forge/vtk-feedstock#13 has been merged please.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 14, 2017

can someone restart this build seeing how conda-forge/vtk-feedstock#13 has been merged please.

Done.

@dfroger
Copy link
Contributor

dfroger commented Jan 14, 2017

I forgot to update the build number in VTK when fixing conda-forge/vtk-feedstock#13, so I'm note sure the VTK package is yet available... See conda-forge/vtk-feedstock#19

EDIT: the VTK package fixing conda-forge/vtk-feedstock#13 is now built and available.

@Cadair
Copy link
Member

Cadair commented Jan 15, 2017

@dfroger Should this be restarted now? As conda-forge/vtk-feedstock#19 has been merged?

@dfroger
Copy link
Contributor

dfroger commented Jan 15, 2017

@Cadair there is another error when importing vtk on circleci:

ImportError: No module named vtkRenderingOpenGLPython

I think we need to add the same yum_requirements.txt as in vtk feedstock.

We should also skip build on OSX and linux+py34, as in vtk recipe. (I don't know why OSX and linux+py34 are skipped for VTK).

And there are also errors on appveyor that may need to be fixed...

EDIT: I created PR #2215 with these proposed changes.

@dfroger dfroger mentioned this pull request Jan 15, 2017
@dfroger
Copy link
Contributor

dfroger commented Jan 17, 2017

this can be closed, as #2215 is merged. Other PR coming for windows and osx...

@jakirkham jakirkham closed this Jan 18, 2017
@hadim hadim deleted the mayavi branch November 4, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants