-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mayavi recipe #2014
Add mayavi recipe #2014
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mayavi:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Waiting for an answer there enthought/mayavi#457 |
Hi @hadim. If you have time to take this over from #1581 that is fine by me. One reason aside from lack of time that I have not updated #1581, was that I forgot that VTK was not being built on all platforms due to time limits at the free CI services. For example, the VTK feedstock does not build any OS X packages (or a python 3.4 package on linux). The same skip line from the VTK recipe will need to be present in the mayavi recipe. |
Well I thought the issue was easier to fix than it is. Maybe we should both keep our PRs open and wait for help or more time to fix it. |
can someone restart this build seeing how conda-forge/vtk-feedstock#13 has been merged please. |
Done. |
I forgot to update the build number in VTK when fixing conda-forge/vtk-feedstock#13, so I'm note sure the VTK package is yet available... See conda-forge/vtk-feedstock#19 EDIT: the VTK package fixing conda-forge/vtk-feedstock#13 is now built and available. |
@dfroger Should this be restarted now? As conda-forge/vtk-feedstock#19 has been merged? |
@Cadair there is another error when importing
I think we need to add the same yum_requirements.txt as in vtk feedstock. We should also skip build on OSX and linux+py34, as in vtk recipe. (I don't know why OSX and linux+py34 are skipped for VTK). And there are also errors on appveyor that may need to be fixed... EDIT: I created PR #2215 with these proposed changes. |
this can be closed, as #2215 is merged. Other PR coming for windows and osx... |
A revival of #1581