update build number #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Also add yourself to the recipe maintainers, while you're at it ;) |
|
Ok, seems I'm already in the recipes maintainers, I'll check. Or maybe the binaries on anaconda.org are not rebuild until build number is increased? |
|
FYI there is no overwriting of existing packages. |
dfroger
force-pushed
the
mayavi-segfault-build-number
branch
from
29342ed to
c888ba6
Compare
In the meantime, another PR has been merged, increasing build number.
|
I've rebased on master. @jakirkham ok, I think so actually. So there is no problem. |
|
ready for the merge! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both PR #15 and #12 have increased build number from 0 to 1.
PR #15 should have increase build number from 1 to 2 instead.
I don't know how much it's a problem that PR #15 has wrong build number. Maybe binaries on anaconda.org will overwrite those from PR #12, and user having already installed binaries with build number 1 will not be able to update to the new binaries including PR #15 (as the build number is the same, the package will be considered up to date)?