Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pyrte_rrtmgp recipe #25894

Merged
merged 29 commits into from
Nov 25, 2024

Conversation

giancastro
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyrte_rrtmgp) and found some lint.

Here's what I've got...

For recipes/pyrte_rrtmgp:

  • The following maintainers have not yet confirmed that they are willing to be listed here: tcmetzger, RobertPincus. Please ask them to comment on this PR if they are.
  • requirements: build: libuv==1.44.2 must contain a space between the name and the pin, i.e. libuv ==1.44.2
  • requirements: build: cmake==3.26.4 must contain a space between the name and the pin, i.e. cmake ==3.26.4

For recipes/pyrte_rrtmgp:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyrte_rrtmgp) and found some lint.

Here's what I've got...

For recipes/pyrte_rrtmgp:

  • about/license_family 'BSD-3-Clause' not allowed. Allowed families are
    AGPL, APACHE, BSD, CC, GPL, GPL2, GPL3, LGPL, MIT, MOZILLA, NONE,
    OTHER, PROPRIETARY, PSF, and PUBLIC-DOMAIN.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyrte_rrtmgp) and found some lint.

Here's what I've got...

For recipes/pyrte_rrtmgp:

  • The top level meta key target_platform is unexpected

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyrte_rrtmgp) and found some lint.

Here's what I've got...

For recipes/pyrte_rrtmgp:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [14]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyrte_rrtmgp) and found it was in an excellent condition.

@giancastro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@martin-g
Copy link

@conda-forge-admin please rerender

@jaimergp
Copy link
Member

staged-recipes doesn't need to be rerendered. You can skip things but also feel free to ignore those builds that do not matter. Once approved and merged, the resulting feedstock will only generate the config for the platforms that are not skipped.

@RobertPincus
Copy link

I am willing to act as a maintainer of this recipe.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 19, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyrte_rrtmgp/meta.yaml) and found some lint.

Here's what I've got...

For recipes/pyrte_rrtmgp/meta.yaml:

For recipes/pyrte_rrtmgp/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyrte_rrtmgp/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pyrte_rrtmgp/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyrte_rrtmgp/meta.yaml) and found it was in an excellent condition.

@giancastro giancastro requested a review from jaimergp November 21, 2024 14:41
@giancastro
Copy link
Contributor Author

@conda-forge/help-python, ready for review!

recipes/pyrte_rrtmgp/meta.yaml Outdated Show resolved Hide resolved
recipes/pyrte_rrtmgp/meta.yaml Outdated Show resolved Hide resolved
giancastro and others added 2 commits November 25, 2024 07:53
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@giancastro giancastro requested a review from xhochy November 25, 2024 11:09
@xhochy xhochy merged commit f80a6eb into conda-forge:main Nov 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants