Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda forge infrastructure #24

Open
1 of 2 tasks
tcmetzger opened this issue Mar 27, 2024 · 7 comments
Open
1 of 2 tasks

Add conda forge infrastructure #24

tcmetzger opened this issue Mar 27, 2024 · 7 comments
Assignees
Milestone

Comments

@tcmetzger
Copy link
Collaborator

tcmetzger commented Mar 27, 2024

Update our existing conda recipe and build infrastructure to publish the package on conda forge (for Linux/Ubuntu x86 only, for now).

Goals:

  • On a Ubuntu 64-x86 system, the package is installable with conda install pyrte_rrtmgp (or equivalent) (or at least: our entry to conda forge is under review)
  • The installation instructions in the readme reflect the new option to install via conda forge
@tcmetzger tcmetzger assigned giancastro and unassigned giancastro Mar 27, 2024
@tcmetzger
Copy link
Collaborator Author

PR on conda forge: conda-forge/staged-recipes#25894

Currently on pause until an official release of RTE RRTMGP is available.

@tcmetzger tcmetzger added this to the Future milestone Apr 9, 2024
@RobertPincus
Copy link
Member

v1.8 of RTE+RRTMGP contains the kernel API C header files.

@tcmetzger
Copy link
Collaborator Author

tcmetzger commented Nov 20, 2024

From our 11/20 call:

  • The data is different from the python code. we should have a separate conda package pyrte-data (just the scheme data). pyrte could then have that as a dependency. (https://github.com/earth-system-radiation/rrtmgp-data)
  • Also: don't really run the tests during conda build (we test thoroughly in our CI/CD pipeline in the repo), to avoid hitting the restrictions of the conda build vm.

@tcmetzger
Copy link
Collaborator Author

@giancastro Somewhat related to this, it seems like we'll need to find a better way to download and store the test data, in cases where a user has installed the package from conda!

@RobertPincus
Copy link
Member

@tcmetzger I thought the idea was to have another Conda package with data?

@tcmetzger
Copy link
Collaborator Author

tcmetzger commented Dec 4, 2024

Yes, that is what we'll do - part of this is to define where to store that data from the conda package so that it is accessible to the tests, etc. (as defined in #24 (comment)).

@RobertPincus @sehnem Could you add a comment here to define which data (i.e. which folders or files) from https://github.com/earth-system-radiation/rrtmgp-data should be included in the future pyrte-data package?

Edit: superseded, see below

@tcmetzger
Copy link
Collaborator Author

From our 2024/12/04 discussion:
We decided that the current implementation and function for downloading the data is sufficient for now. The only use case we want to cover is: after the user installs the conda package into their local environment, they want some way of verifying that the package works correctly. This could be some small "healthcheck" CLI command that downloads a small amount of data and runs a subset of the pytests.

@brendancol and @giancastro to look into this in #73

@tcmetzger tcmetzger moved this from To Do to In progress in pyRTE Phase 2 Dec 4, 2024
@tcmetzger tcmetzger moved this from In progress to In review in pyRTE Phase 2 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

No branches or pull requests

4 participants