Add vs2008_runtime #4728

jakirkham · 2018-01-03T04:01:26Z

Adds a package for vs2008_runtime for conda-forge using AppVeyor. Uses the strategy proposed in this comment due to some oddities with AppVeyor's VS 2008 install.

conda-forge-linter · 2018-01-03T04:01:37Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vs2008_runtime) and found it was in an excellent condition.

jakirkham · 2018-01-03T07:17:09Z

recipes/vs2008_runtime/bld.bat

@@ -0,0 +1,26 @@
+for /F "usebackq tokens=3*" %%A in (`REG QUERY "HKEY_LOCAL_MACHINE\Software\Microsoft\DevDiv\VC\Servicing\9.0\IDE" /v UpdateVersion`) do (


Do you know how to query the runtime library version number from the registry or CMake for VS 2008, @isuruf? I'm pretty sure what I have here is wrong. Though without a Windows machine at hand, it's proving difficult to find out.

Pushed an untested fix. Let's see if it works

Thanks @isuruf. Nice fix!

jakirkham · 2018-01-03T08:55:39Z

Now if we can only figure out why cmake refuses to copy vcomp, we should be in a good place.

Edit: Maybe it's not included with this install? 😕

Edit 2: Raised as issue ( appveyor/ci#2008 ).

jakirkham · 2018-01-03T15:46:16Z

Thanks for exploring this with me @isuruf. I'm wondering if AppVeyor actually installs vcomp90 at this point. Think we might be able to fix this by installing Microsoft Visual C++ 2008 SP1 Redistributable Packages for 32-bit and 64-bit. Have pushed a commit to test this theory.

These should hopefully have the missing `vcomp90` library in them. So add this hack to `bld.bat` temporarily to see if this fixes the issue.

isuruf · 2018-01-04T09:09:19Z

recipes/vs2008_runtime/meta.yaml

@@ -0,0 +1,33 @@
+package:
+  name: vs2008_runtime
+  version: "9.0.30729.6161"


@jakirkham, I updated to 9.0.30729.6161 which is the SP1 MFC security update

Sounds fine to me. As long as we are equal to or greater than (which this is) defaults copy, I think we should be ok.

isuruf · 2018-01-04T09:10:09Z

recipes/vs2008_runtime/bld.bat

+    set "ARCH_DIR=amd64"
+)
+
+cd C:\Windows\WinSxS\%ARCH_DIR%_microsoft.vc90.openmp_*_%PKG_VERSION%_*


We are using the exact version here, so all of the dlls are actually coming from the SP1 MFC update

Could you please add the original link to where these were downloaded from in a comment?

Done above.

isuruf · 2018-01-04T09:10:42Z

recipes/vs2008_runtime/meta.yaml

+        "vcomp90"
+    ] %}
+    {% for each_lib in libs %}
+    - if not exist "%PREFIX%\\{{ each_lib }}.dll" exit 1


Defaults is placing the dlls in %PREFIX% and %LIBRARY_BIN%, so did the same here

Thanks for pointing this out.

[ci skip]

jakirkham · 2018-01-04T14:38:40Z

recipes/vs2008_runtime/meta.yaml

+extra:
+  recipe-maintainers:
+    - gillins
+    - isuruf


Went ahead and added you as a maintainer, @isuruf. Please let me know if that is ok.

jakirkham · 2018-01-04T14:39:00Z

recipes/vs2008_runtime/meta.yaml

+
+extra:
+  recipe-maintainers:
+    - gillins


@gillins, are you still happy to be a maintainer here?

jakirkham · 2018-01-04T14:39:19Z

recipes/vs2008_runtime/meta.yaml

+  recipe-maintainers:
+    - gillins
+    - isuruf
+    - mingwandroid


@mingwandroid, are you still happy to be a maintainer here?

jakirkham · 2018-01-04T14:39:48Z

recipes/vs2008_runtime/meta.yaml

+    - gillins
+    - isuruf
+    - mingwandroid
+    - msarahan


@msarahan, are you still happy to be a maintainer here?

jakirkham · 2018-01-04T15:45:25Z

So do we want to keep the vcredist installs in this recipe and make a note that it requires administrative privileges or would we rather add them to vs2008_express_vc_python_patch where it already requires administrative privileges?

isuruf · 2018-01-04T15:47:29Z

We can pass through the env variable CI and install the vcredist if it's set

jakirkham · 2018-01-04T16:17:27Z

That seems like a reasonable suggestion.

jakirkham · 2018-01-04T16:27:50Z

One last question, could we validate these downloads against some kind of checksum?

isuruf · 2018-01-04T16:56:24Z

Done

jakirkham · 2018-01-04T17:01:55Z

Beautiful. Thanks @isuruf. :)

I think we are ok to merge.

jakirkham · 2018-01-04T19:13:22Z

@conda-forge/core @conda-forge/staged-recipes, this is ready for a final review. :)

scopatz · 2018-01-04T20:08:56Z

recipes/vs2008_runtime/meta.yaml

+
+about:
+  home: http://www.microsoft.com
+  license: Proprietary


Is this OK?

Yes. They tell us that we can redistribute the runtime libraries. Anything not in that list comes from this Microsoft Redistribution, which exists for this purpose.

Also from a very old discussion that happened on this same topic would highlight this comment as well.

jakirkham · 2018-01-04T22:50:22Z

Anything else?

jakirkham · 2018-01-05T19:31:48Z

Is it alright if we merge?

patricksnape · 2018-01-05T23:07:58Z

Great work guys

jakirkham · 2018-01-05T23:26:53Z

Thanks everyone!

jakirkham added the Package request label Jan 3, 2018

jakirkham force-pushed the add_vs2008_runtime branch 13 times, most recently from 4c25ee8 to 186064c Compare January 3, 2018 06:27

recipes: Add vs2008_runtime

7a9008e

jakirkham force-pushed the add_vs2008_runtime branch from 186064c to 7a9008e Compare January 3, 2018 06:33

wip

92855c5

jakirkham commented Jan 3, 2018

View reviewed changes

jakirkham mentioned this pull request Jan 3, 2018

Resurrect vs2008_runtime and vs2010_runtime #4725

Closed

isuruf added 2 commits January 3, 2018 13:08

Check for version using cmake

6f0bf6d

Fix version detection

6eb3611

Don't use 3.10.0 as it's buggy

5ef73fc

isuruf force-pushed the add_vs2008_runtime branch from db967ea to 5ef73fc Compare January 3, 2018 09:39

cmake <3.9.2 is buggy as well

3141e69

jakirkham force-pushed the add_vs2008_runtime branch from 901c50e to 0b6b0e1 Compare January 3, 2018 15:50

Install Visual C++ 2008 SP1 Redistributables

9c06135

These should hopefully have the missing `vcomp90` library in them. So add this hack to `bld.bat` temporarily to see if this fixes the issue.

jakirkham force-pushed the add_vs2008_runtime branch from 0b6b0e1 to 9c06135 Compare January 3, 2018 15:58

isuruf added 2 commits January 4, 2018 14:28

Remove unnecessary CMakeLists.txt

0ca6de2

Fix download url

97ccc95

isuruf reviewed Jan 4, 2018

View reviewed changes

isuruf changed the title ~~WIP: Add vs2008_runtime~~ Add vs2008_runtime Jan 4, 2018

Add @isuruf as a maintainer

49eebdb

[ci skip]

jakirkham commented Jan 4, 2018

View reviewed changes

recipes/vs2008_runtime/meta.yaml

extra:

recipe-maintainers:

- gillins

Copy link

Member Author

jakirkham Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gillins, are you still happy to be a maintainer here?

jakirkham commented Jan 4, 2018

View reviewed changes

Add link to download url

44745b8

Install vcredist only if run on CI

367aa1e

Use source to download vcredist.exe

cac0d86

scopatz reviewed Jan 4, 2018

View reviewed changes

patricksnape approved these changes Jan 4, 2018

View reviewed changes

jakirkham mentioned this pull request Jan 5, 2018

add vs runtime packages #809

Merged

patricksnape merged commit ed9464a into conda-forge:master Jan 5, 2018

jakirkham deleted the add_vs2008_runtime branch January 5, 2018 23:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add vs2008_runtime #4728

Add vs2008_runtime #4728

jakirkham commented Jan 3, 2018 •

edited

Loading

conda-forge-linter commented Jan 3, 2018

jakirkham Jan 3, 2018

isuruf Jan 3, 2018

jakirkham Jan 3, 2018

jakirkham commented Jan 3, 2018 •

edited

Loading

jakirkham commented Jan 3, 2018

isuruf Jan 4, 2018

jakirkham Jan 4, 2018

isuruf Jan 4, 2018

jakirkham Jan 4, 2018

jakirkham Jan 4, 2018

isuruf Jan 4, 2018

jakirkham Jan 4, 2018

jakirkham Jan 4, 2018

isuruf Jan 4, 2018

jakirkham Jan 4, 2018

jakirkham Jan 4, 2018

jakirkham Jan 4, 2018

jakirkham commented Jan 4, 2018 •

edited

Loading

isuruf commented Jan 4, 2018

jakirkham commented Jan 4, 2018

jakirkham commented Jan 4, 2018

isuruf commented Jan 4, 2018

jakirkham commented Jan 4, 2018

jakirkham commented Jan 4, 2018

scopatz Jan 4, 2018

jakirkham Jan 4, 2018

jakirkham Jan 4, 2018

jakirkham commented Jan 4, 2018

jakirkham commented Jan 5, 2018

patricksnape commented Jan 5, 2018 •

edited

Loading

jakirkham commented Jan 5, 2018

		@@ -0,0 +1,26 @@
		for /F "usebackq tokens=3*" %%A in (`REG QUERY "HKEY_LOCAL_MACHINE\Software\Microsoft\DevDiv\VC\Servicing\9.0\IDE" /v UpdateVersion`) do (

Add vs2008_runtime #4728

Add vs2008_runtime #4728

Conversation

jakirkham commented Jan 3, 2018 • edited Loading

conda-forge-linter commented Jan 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Jan 3, 2018 • edited Loading

jakirkham commented Jan 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Jan 4, 2018 • edited Loading

isuruf commented Jan 4, 2018

jakirkham commented Jan 4, 2018

jakirkham commented Jan 4, 2018

isuruf commented Jan 4, 2018

jakirkham commented Jan 4, 2018

jakirkham commented Jan 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Jan 4, 2018

jakirkham commented Jan 5, 2018

patricksnape commented Jan 5, 2018 • edited Loading

jakirkham commented Jan 5, 2018

jakirkham commented Jan 3, 2018 •

edited

Loading

jakirkham commented Jan 3, 2018 •

edited

Loading

jakirkham commented Jan 4, 2018 •

edited

Loading

patricksnape commented Jan 5, 2018 •

edited

Loading