Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vs2008_runtime #4728

Merged
merged 16 commits into from
Jan 5, 2018
Merged

Add vs2008_runtime #4728

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7a9008e
recipes: Add vs2008_runtime
jakirkham Jan 3, 2018
92855c5
wip
jakirkham Jan 3, 2018
6f0bf6d
Check for version using cmake
isuruf Jan 3, 2018
6eb3611
Fix version detection
isuruf Jan 3, 2018
5ef73fc
Don't use 3.10.0 as it's buggy
isuruf Jan 3, 2018
3141e69
cmake <3.9.2 is buggy as well
isuruf Jan 3, 2018
9c06135
Install Visual C++ 2008 SP1 Redistributables
jakirkham Jan 3, 2018
556b7dd
Revert "Install Visual C++ 2008 SP1 Redistributables"
jakirkham Jan 4, 2018
95c96ab
Add WinSxS path to vcomp90
jakirkham Jan 4, 2018
407b55c
Use SP1 MFC update
isuruf Jan 4, 2018
0ca6de2
Remove unnecessary CMakeLists.txt
isuruf Jan 4, 2018
97ccc95
Fix download url
isuruf Jan 4, 2018
49eebdb
Add @isuruf as a maintainer
jakirkham Jan 4, 2018
44745b8
Add link to download url
isuruf Jan 4, 2018
367aa1e
Install vcredist only if run on CI
isuruf Jan 4, 2018
cac0d86
Use source to download vcredist.exe
isuruf Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions recipes/vs2008_runtime/bld.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
if "%ARCH%" == "32" (
powershell -Command "(New-Object Net.WebClient).DownloadFile('https://download.microsoft.com/download/5/D/8/5D8C65CB-C849-4025-8E95-C3966CAFD8AE/vcredist_x86.exe', 'vcredist_x86.exe')"
if errorlevel 1 exit 1
vcredist_x86.exe /qb!
if errorlevel 1 exit 1
set "ARCH_DIR=x86"
)


if "%ARCH%" == "64" (
powershell -Command "(New-Object Net.WebClient).DownloadFile('https://download.microsoft.com/download/5/D/8/5D8C65CB-C849-4025-8E95-C3966CAFD8AE/vcredist_x64.exe', 'vcredist_x64.exe')"
if errorlevel 1 exit 1
vcredist_x64.exe /qb!
if errorlevel 1 exit 1
set "ARCH_DIR=amd64"
)

cd C:\Windows\WinSxS\%ARCH_DIR%_microsoft.vc90.openmp_*_%PKG_VERSION%_*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using the exact version here, so all of the dlls are actually coming from the SP1 MFC update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the original link to where these were downloaded from in a comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done above.

xcopy *.dll %LIBRARY_BIN%
xcopy *.dll %PREFIX%

cd C:\Windows\WinSxS\%ARCH_DIR%_microsoft.vc90.crt_*_%PKG_VERSION%_*
xcopy *.dll %LIBRARY_BIN%
xcopy *.dll %PREFIX%

cd %SRC_DIR%
34 changes: 34 additions & 0 deletions recipes/vs2008_runtime/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
package:
name: vs2008_runtime
version: "9.0.30729.6161"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham, I updated to 9.0.30729.6161 which is the SP1 MFC security update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine to me. As long as we are equal to or greater than (which this is) defaults copy, I think we should be ok.


build:
number: 0
skip: true # [not win]
msvc_compiler: 9.0

test:
commands:
{% set libs = [
"msvcm90",
"msvcp90",
"msvcr90",
"vcomp90"
] %}
{% for each_lib in libs %}
- if not exist "%PREFIX%\\{{ each_lib }}.dll" exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults is placing the dlls in %PREFIX% and %LIBRARY_BIN%, so did the same here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out.

- if not exist "%PREFIX%\\Library\\bin\\{{ each_lib }}.dll" exit 1
{% endfor %}

about:
home: http://www.microsoft.com
license: Proprietary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this OK?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. They tell us that we can redistribute the runtime libraries. Anything not in that list comes from this Microsoft Redistribution, which exists for this purpose.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also from a very old discussion that happened on this same topic would highlight this comment as well.

summary: Bundles of the MSVC 9 (VS 2008) runtime

extra:
recipe-maintainers:
- gillins
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gillins, are you still happy to be a maintainer here?

- isuruf
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and added you as a maintainer, @isuruf. Please let me know if that is ok.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

- mingwandroid
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingwandroid, are you still happy to be a maintainer here?

- msarahan
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msarahan, are you still happy to be a maintainer here?

- patricksnape