Activation script does not pick up VSINSTALLDIR on GitHub runners

[marcoesters]

Solution to issue cannot be found in the documentation.

• I checked the documentation.

Issue

Recently, GitHub has remove a lot of Visual Studio components: actions/runner-images#9853

This has caused conda build pipelines to fail: actions/runner-images#9888

I noticed the same thing with the menuinst canary builds. While building the recipe, I saw that cl.exe failed with the following error:

    cl.exe /c /nologo /O2 /W3 /GL /DNDEBUG /MD -Isrc/ -ID:\a\menuinst\menuinst\pkgs\menuinst_1716241405125\_h_env\include -ID:\a\menuinst\menuinst\pkgs\menuinst_1716241405125\_h_env\Include -ID:\a\menuinst\menuinst\pkgs\menuinst_1716241405125\_h_env\Library\include -ID:\a\menuinst\menuinst\pkgs\menuinst_1716241405125\_h_env\Library\include /d1trimfile:D:\a\menuinst\menuinst\pkgs\menuinst_1716241405125\work /EHsc /Tpsrc/winshortcut.cpp /Fobuild\temp.win-amd64-cpython-310\Release\src/winshortcut.obj
    error: command 'cl.exe' failed: None
    error: subprocess-exited-with-error

This build had run successfully before the GitHub runner update. Something I noticed is that since the update, activate.bat is unable to find the installation path. Previously, vswhere was able to pick up VSINSTALLDIR: https://github.com/conda/menuinst/actions/runs/9103078129/job/25024300180#step:5:1434

Now, even with the recent update for #73, VSINSTALLDIR remains empty and then tries a few fallbacks, which do not exist either: https://github.com/conda/menuinst/actions/runs/9103078129/job/25198654933#step:5:1554

Note: since this happens on a CI that I can't change for debugging, I added the output of the conda build process that installs the conda-forge compilers.

Installed packages

The following NEW packages will be INSTALLED:
  
      bzip2:           1.0.8-hcfcfb64_5           conda-forge
      ca-certificates: 2024.2.2-h56e8100_0        conda-forge
      libffi:          3.4.2-h8ffe710_5           conda-forge
      libsqlite:       3.45.3-hcfcfb64_0          conda-forge
      libzlib:         1.2.13-hcfcfb64_5          conda-forge
      openssl:         3.3.0-hcfcfb64_0           conda-forge
      pip:             24.0-pyhd8ed1ab_0          conda-forge
      python:          3.10.14-h4de0772_0_cpython conda-forge
      setuptools:      69.5.1-pyhd8ed1ab_0        conda-forge
      tk:              8.6.13-h5226925_1          conda-forge
      tzdata:          2024a-h0c530f3_0           conda-forge
      ucrt:            10.0.22621.0-h57928b3_0    conda-forge
      vc:              14.3-ha32ba9b_20           conda-forge
      vc14_runtime:    14.38.33135-h835141b_20    conda-forge
      vs2015_runtime:  14.38.33135-h22015db_20    conda-forge
      vs2017_win-64:   19.16.27033-hddac466_20    conda-forge
      vswhere:         3.1.4-h57928b3_0           conda-forge
      wheel:           0.43.0-pyhd8ed1ab_1        conda-forge
      xz:              5.2.6-h8d14728_0           conda-forge

Environment info

active environment : base
      active env location : C:\Miniconda
              shell level : 3
         user config file : C:\Users\runneradmin\.condarc
   populated config files : C:\Users\runneradmin\.condarc
            conda version : 24.5.0
      conda-build version : 24.5.0
           python version : 3.12.2.final.0
                   solver : libmamba (default)
         virtual packages : __archspec=1=x86_64_v3
                            __conda=24.5.0=0
                            __win=0=0
         base environment : C:\Miniconda  (writable)
        conda av data dir : C:\Miniconda\etc\conda
    conda av metadata url : None
             channel URLs : https://repo.anaconda.com/pkgs/main/win-64
                            https://repo.anaconda.com/pkgs/main/noarch
                            https://repo.anaconda.com/pkgs/r/win-64
                            https://repo.anaconda.com/pkgs/r/noarch
                            https://repo.anaconda.com/pkgs/msys2/win-64
                            https://repo.anaconda.com/pkgs/msys2/noarch
            package cache : C:\Users\runneradmin\conda_pkgs_dir
         envs directories : C:\Miniconda\envs
                            C:\Users\runneradmin\.conda\envs
                            C:\Users\runneradmin\AppData\Local\conda\conda\envs
                 platform : win-64
               user-agent : conda/24.5.0 requests/2.31.0 CPython/3.12.2 Windows/2022Server Windows/10.0.20348 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8
            administrator : True
               netrc file : None
             offline mode : False

[isuruf]

They've removed v141 components. Please try vs2019_win-64 or vs2022_win-64 instead of vs2017_win-64