Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry using VS2019 or newer #128

Closed
h-vetinari opened this issue Feb 4, 2024 · 11 comments
Closed

Retry using VS2019 or newer #128

h-vetinari opened this issue Feb 4, 2024 · 11 comments

Comments

@h-vetinari
Copy link
Member

h-vetinari commented Feb 4, 2024

About 1.5 years ago, be57b0f went back to VS2017 due to some apparent issues at the time. It would be good to remove

# Seems like vigra isn't really compatible with new compilers
c_compiler: # [win]
- vs2017 # [win]
cxx_compiler: # [win]
- vs2017 # [win]

and just use the conda-forge default compilers, as vigra is among the last feedstocks in conda-forge to still use VS2017.

Hopefully vigra has become compatible with newer VS in the meantime... 🤞

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 4, 2024

@conda-forge-admin please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I started rerendering the recipe in #129.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 4, 2024

It seems we are still having errors with the latest version.

I remember I had tracked it down a bit, but never got to the bottom of it:
ukoethe/vigra#525

@h-vetinari
Copy link
Member Author

Thanks for checking!

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 4, 2024

this might be a compiler error. the iterator has a const and a non-const version. is there a newer compiler version? 2022??

@h-vetinari
Copy link
Member Author

is there a newer compiler version? 2022??

Yes, vs2022. Should be functional; if not, let us know on the vc-feedstock.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 4, 2024

hmm ok lets try.

@h-vetinari h-vetinari changed the title Retry using VS2019 Retry using VS2019+ May 21, 2024
@h-vetinari h-vetinari changed the title Retry using VS2019+ Retry using VS2019 or newer May 21, 2024
@h-vetinari
Copy link
Member Author

Fixed by #131

@hmaarrfk
Copy link
Contributor

but only in the sense that i gave up even more ;)

@h-vetinari
Copy link
Member Author

Also in the sense that there's no more vs2017 components in the Azure images: conda-forge/vc-feedstock#78

@hmaarrfk
Copy link
Contributor

oh.... really lucky that I gave up at the right time!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants