Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvigra - Disable Python+Numpy support + Rebuild for libboost 1.84 #131

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update boost1840.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8433703260, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

Thanks for adding the required libboost-devel host-dep! This now runs fine everywhere but on windows, where we run into:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.38.33130\include\algorithm(7928): error C3892: '_First': you cannot assign to a variable that is const

and

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.38.33130\include\algorithm(8016): error C2664: 'void std::swap(std::thread &,std::thread &) noexcept': cannot convert argument 1 from 'T' to 'std::thread &'

I'm pretty sure the STL being used here is not compatible with VS2017 anymore, so you're going to have to upgrade I think.

@hmaarrfk
Copy link
Contributor

we've been trying to update our compiler:
ukoethe/vigra#547

but we haven't had much success. your help there would be appreciated!

@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 9, 2024

I am unfortunately not sure what to do about windows support. we might have to drop it unless somebody can help with patches upstream.

I'll open an issue to this effect.

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

@jakirkham @stuarteberg any strong objections in skipping windows?

@hmaarrfk
Copy link
Contributor

sigh, now osx fails lol. at least it is with the same problem as windows!

@k-dominik
Copy link
Contributor

that's great, debugging the windows issue meant yanky vms for me, while on mac I can at least stay on my machine!

@hmaarrfk hmaarrfk changed the title Rebuild for libboost 1.84 Disable Python+Numpy support + Rebuild for libboost 1.84 Jun 9, 2024
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Jun 9, 2024

On my environment:

mamba repoquery whoneeds vigra

Executing the query vigra



 Name       Version  Build               Depends                  Channel     Subdir
───────────────────────────────────────────────────────────────────────────────────────
 enblend    4.3      pl5321h8f5525c_13   vigra >=1.11.2,<1.12.0a0 conda-forge linux-64
 hugin-base 2023.0.0 pl5321h6c166bd_1    conda-forge              linux-64

only c libraries are using vigra

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Jun 9, 2024

Maybe I should just release "libvigra" and make it conflict with other vigra packages.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • pin_compatible should be used instead of pin_subpackage for vigra because it is not a known output of this recipe: ['libvigra'].

@hmaarrfk hmaarrfk force-pushed the rebuild-boost1840-0-1_hbb8cdc branch from ec4cc76 to 33a623d Compare June 9, 2024 23:42
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

Ok I'll try to leave this open until June 16 (ok i'm not setting reminders, but I'll eventually get back to this and this is a promise to my future self to be patient)

if there are no concerns about this recipe I'll merge.

@hmaarrfk hmaarrfk changed the title Disable Python+Numpy support + Rebuild for libboost 1.84 libvigra - Disable Python+Numpy support + Rebuild for libboost 1.84 Jun 10, 2024
@hmaarrfk hmaarrfk merged commit c16ecda into conda-forge:main Jun 17, 2024
8 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-boost1840-0-1_hbb8cdc branch June 17, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants