Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ability to edit locked environments #282

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

steff456
Copy link
Contributor

@steff456 steff456 commented Sep 1, 2023

Fixes #203.

Description

This pull request:

  • Enable showEditButton props to disable the ability to edit locked environments

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

Now the edit button is disabled if the environment is locked,

image

@steff456 steff456 added type: enhancement 💅🏼 New feature or request area: user experience 👩🏻‍💻 Items impacting the end-user experience labels Sep 1, 2023
@steff456 steff456 added this to the 🚀 JATIC - Q1 milestone Sep 1, 2023
@steff456 steff456 self-assigned this Sep 1, 2023
@kcpevey
Copy link
Contributor

kcpevey commented Sep 19, 2023

@trallard says this is blocked until we have a discussion on workflows.

@trallard
Copy link
Collaborator

Unblocked - now that we can discuss workflows!

@kcpevey
Copy link
Contributor

kcpevey commented Oct 24, 2023

We need to think through roles both in conda-store and how this relates to Nebari.

On the conda-store side - we need to make sure that we have conda-store role distinctions that can edit or only view - We believe this exists, @steff456/ @nkaretnikov will define what is available.

On the Nebari side - we need to make sure that we have nebari role distinctions that can edit or only view - the relationship between these two roles needs to be explored.

@kcpevey
Copy link
Contributor

kcpevey commented Oct 24, 2023

This work should be done with the changes that are being implemented in conda-incubator/conda-store#491 in mind.

@costrouc
Copy link
Member

Blocked. This needs a follow up from @trallard. @steff456 please discuss this with @trallard and the blockers.

@trallard trallard merged commit 788310f into conda-incubator:main Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: user experience 👩🏻‍💻 Items impacting the end-user experience needs: discussion 💬 type: enhancement 💅🏼 New feature or request
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Disable ability to edit locked environments
5 participants