-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CEP 8 - Conda Release Schedule #26
Conversation
a749182
to
28a3362
Compare
28a3362
to
0bf13a1
Compare
With this new versioning scheme anything can change at a MINOR release and only patches/bug fixes happen a MICRO? The only way to know about upcoming breaking changes is via changelogs or deprecation messages? |
@carterbox Correct but we are also working on defining a new deprecation policy in a separate CEP (see #27). The objective of moving to CalVer is to remove the guesswork on maintainers of deciding if certain changes warrant a Per the ideas proposed in #27, deprecations/breaking changes are intended to be handled more graciously than they have in the past. Features would be marked as pending deprecation at any point but would only be deprecated and eventually removed after a number of regular (not optional/hotfix) releases. |
f328e91
to
90696a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just some grammar related changes and other suggestions for improvements.
3cbaf98
to
4079a74
Compare
4079a74
to
9ba4ac5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all for the thoughtfulness put into this!
Co-authored-by: Jannis Leidel <jannis@leidel.info>
@conda-incubator/steering This PR falls under the Enhancement Proposal Approval policy of the conda governance policy, please vote and/or comment on this PR. This PR needs 60% of the Steering Council to vote yea to pass. To vote please leave Approve (yea) or Request Changes (nay) pull request reviews. If you would like changes to the current language please leave a comment (in the PR) or push to this branch. This vote will end on 2022-08-12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. And what-if scenario: suppose folks are changing jobs and there isn't anyone to issue an expected release? Is this a promise to users and they'll feel that something is amiss if a release is skipped? Or is this only some guidelines and skipping one or another will be communicated as "OK."
Does that make sense? Sorry, I'm trying to put a corporate hat of someone expecting a release that won't come. But I'm terrible at playing corporate.
This is intended to be a release schedule promise held by the conda org to our users. Ideally, releases should be a shared community responsibility to encourage knowledge sharing (should probably create a release subteam that can cater to this). |
Is there any kind of contingency for if no changes have occurred since the last release? This document makes me think that a release will happen no matter what, every 2 months. Of course, it's silly to release identical code with a new version, but we don't explicitly preclude that possibility. In that vein, is there a time window where changes are expected to make it into the next release? What are the code cutoffs for each of the various cycles? Does that belong in this doc or elsewhere? |
@msarahan Good point, that seems like a reasonable and likely scenario (in the future), I'd suggest adding a point like:
|
That is my concern and a promise that can be broken by something as silly as "there isn't someone available right now for a release" or "there is no change in the code base" is not something that will build trust from users.
That works for me @jezdez. Thanks! |
Is it worth discussing my second point?
if you’d rather not get into those weeds, I understand. |
@msarahan Oh sorry, I don't have a strong opinion on this one. I'd say that's a decision the release manager(s) get to make? Obviously large changes shouldn't be crammed in last minute but small fixes (e.g. typos and other minor corrections) could be included without too much trouble. |
@conda-incubator/steering This vote falls under the Enhancement Proposal Approval policy of the conda governance policy, please vote and/or comment on this PR. This vote needs 60% of the Steering Council to vote yea to pass. This vote presently has 6, and needs 4 more for quorum. It is proposed that this vote will time out and be evaluated with the current votes in 7 days, on 2022-08-19. To vote please leave Approve (yea) or Request Changes (nay) reviews. |
Voting ResultsThis was a standard, non-timed-out vote.
This vote has reached quorum (10 + 0 = 10 which is at least 60% of 16). It has also passed since it recorded 10 "yes" votes and 0 "no" votes giving 10/10 which is greater than 60% of 15. It should be noted that a request for change was recorded in the pull request about minor implementation details that do not invalidate the previous votes. The author made the requested change. |
Description
Define a release schedule that is better than today's ad hoc releases by borrowing ideas from Python, Django, and GitLab.
Objectives