Replace number stringification hack with custom YAML loader #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaconda-issue-bot
added
the
cla-signed
kenodegard
force-pushed
the
stringify-numbers
branch
2 times, most recently
from
3b5467b to
fae6188
Compare
|
Yay! All done here! @mingwandroid - no rush just let me know if anything here needs further work/discussion. |
|
@kenodegard You identified a few cases that were previously missing, could you turn those cases into test cases please? |
|
Absolutely! I will need to revive some dormant brain cells first... I'm assuming we'd want the tests written in |
kenodegard
force-pushed
the
stringify-numbers
branch
from
fae6188 to
5901350
Compare
|
@jezdez added a few simple tests that are just checking to see if any int/floats occur in the parsed yaml. The zero, positive, and negative tests all fail on master. |
|
@anaconda-issue-bot check |
Instead of monkeypatching the yaml Loader in an attempt to avoid parsing numbers make a custom Loader where the float/int tags are entirely removed.
kenodegard
force-pushed
the
stringify-numbers
branch
from
5901350 to
dd6bfcb
Compare
kenodegard
changed the title
jezdez
approved these changes
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was prompted by issues identified in #4179.
Instead of monkeypatching the yaml Loader every time it is used in an attempt to avoid parsing numbers make a custom Loader where the float/int tags are entirely removed.
This change also catches a number of cases that were previously missed. For example, pyyaml defined float resolvers for "-+0123456789." and int resolvers for "-+0123456789" and since the prior implementation only monkeypatched for "0123456789" it was still possible for numbers to be missed (e.g. ".0", "-1", "+1").