Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a highly decentralized process of validating the contents and format of the metadata this introduces a schema that is used to validate/standardize the metadata prior to storage/usage.
Using this schema obsoletes the need to check whether a section is an
OPTIONALLY_ITERABLE_FIELDS
and other optional styles of defining the metadata (e.g. "build/run_exports" which can be a simplelist
which implicitly means those values are "weak", or adict
explicitly specifying "weak", "strong", etc. values).This further helps to centralize the checking of the metadata to where it happens all at once upon parsing the metafile and not randomly throughout the build process and at least theoretically should help users to more easily catch metadata issues.
I'm leaving the cleanup process of removing obsolete code to future PRs.