Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Tests Against Windows in GitHub Actions #4353

Merged
merged 10 commits into from
Mar 28, 2022
Merged

Run Tests Against Windows in GitHub Actions #4353

merged 10 commits into from
Mar 28, 2022

Conversation

rchord
Copy link
Contributor

@rchord rchord commented Jan 10, 2022

Adding Windows to Github Actions for tests.

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 10, 2022
@rchord rchord changed the title [WIP] Lets see what happens when just adding windows. [WIP] Run tests against Windows in Github Actions Jan 11, 2022
@beeankha beeankha force-pushed the add-windows-to-github-actions branch from d872c0d to be13c26 Compare March 15, 2022 19:22
@beeankha beeankha force-pushed the add-windows-to-github-actions branch from be13c26 to 6febce1 Compare March 15, 2022 19:23
@kenodegard kenodegard linked an issue Mar 16, 2022 that may be closed by this pull request
Windows conda-build tests need to move to Github Actions #4386
Closed
@beeankha
[WIP] Migrating Windows Tests from Azure Pipeline to GitHub Actions (#…
92e2739 
…4400)

* Initial commit for Azure to GHA migration
* Update line breaks to see if pytest flags are correctly recognized
* Utilize build matrix to call parallel vs serial tests
@beeankha beeankha self-assigned this Mar 22, 2022
@beeankha beeankha changed the title [WIP] Run tests against Windows in Github Actions Run Tests Against Windows in GitHub Actions Mar 25, 2022
@beeankha
Copy link
Member

beeankha commented Mar 25, 2022 •
edited
Loading

This is now ready for review!

  1. The Windows tests are running properly via GitHub Actions
  2. Tests are passing 🎉

Two tests have been marked as xfail but the reason is known and fixing those tests up will be part of work done in the future related to fixing tech debt.

@beeankha beeankha requested a review from a team March 25, 2022 19:36
kenodegard
kenodegard approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@kenodegard kenodegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 This is amazing! Very happy to see that we were able to recover previous xfail tests!

@beeankha beeankha merged commit 806c3f0 into master Mar 28, 2022
@jezdez jezdez deleted the add-windows-to-github-actions branch March 29, 2022 10:21
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kenodegard kenodegard kenodegard approved these changes

Assignees

@beeankha beeankha

@rhoule-anaconda rhoule-anaconda

Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows conda-build tests need to move to Github Actions
5 participants
@rchord @beeankha @kenodegard @anaconda-issue-bot @rhoule-anaconda