Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Two Tests with Xfail #4407

Merged

Conversation

beeankha
Copy link
Member

No description provided.

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 24, 2022
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit about using existing utilities. :shipit:

@@ -112,6 +112,8 @@ def test_pin_compatible_semver(testing_config):
utils.on_win and sys.version_info < (3, 6),
reason="Failing tests on Azure for Python 2.7"
)
@pytest.mark.xfail(sys.platform == "win32",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use conda_build.utils.on_win here as well.

@beeankha beeankha merged commit cd9c775 into conda:add-windows-to-github-actions Mar 24, 2022
@beeankha beeankha deleted the add_xfail_marker branch March 25, 2022 14:29
beeankha added a commit that referenced this pull request Mar 28, 2022
* Initial commit for Azure to GHA migration
* Utilize build matrix to call parallel vs serial tests
* Adding missing visual studio to build for cmake tests
* Mark two package tests with xfail (#4407)
* Remove two xfail markers, update windows test setup to install different version of vctools (#4408)

Co-authored-by: Bianca Henderson <beeankha@gmail.com>
Co-authored-by: rhoule-anaconda <rhoule@anaconda.com>
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants