-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sys.exit
calls in conda_build/metadata.py
#5371
Conversation
CodSpeed Performance ReportMerging #5371 will not alter performanceComparing Summary
|
…ception in test_jinja_typo in test_api_build.py
conda_build/metadata.py
Outdated
sys.exit( | ||
"Error: could not import yaml (required to read meta.yaml " | ||
"files of conda recipes)" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was that basically an implicit dependency? Do we require it now in meta.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that it doesn't say "ruamel.yaml" but that package is certainly a regular dependency now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was previously an optional dependency but is currently listed as a requirement in meta.yml
.
This particular code change is more "cleanup" vs "remove sys.exit
" (per work originally done in this PR), so I will revert this change; once the broken-out parts of the "remove sys.exit
calls" work are merged, the original PR will get rebased and will mostly focus on cleanup.
Description
Replacing
sys.exit
call in a few functions inconda_build/metadata.py
with the newCondaBuildUserError
exception for better error handling, along with corresponding unit tests.The changes in this PR are separated out from work previously done by @kenodegard in #5255
Xref #4209
Checklist - did you ...
Add a file to thenews
directory (using the template) for the next release's release notes?Add / update outdated documentation?