-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sys.exit
calls in conda_build/metadata.py
#5371
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
24656d2
Update exceptions imports/usage in metadata.py
beeankha 7cb1715
Replace sys.exit call with CondaBuildUserError for select_lines() fun…
beeankha ecb9084
Add unit test for CondaBuildUserError exception in select_lines test
beeankha 20273fb
Replace sys.exit call in _git_clean() and add unit test
beeankha eeac2c9
Replace sys.exit call in check_bad_chrs() and add unit test
beeankha 65846a6
Update import statements and remove sys.exit call from yamlize()
beeankha b0a7125
Mark _get_env_path() for deprecation
beeankha 2f9eea1
Remove sys.exit call from parse_until_resolved() and add unit test
beeankha f77866a
Remove sys.exit call from _get_contents()
beeankha 3792dfb
Ignore deprecation warnings in metadata.py tests, point to correct ex…
beeankha ab8811f
Relax match string in error assertion for Windows
beeankha 12fd2ae
Merge branch 'main' into sys.exit-select_lines
beeankha d4f3eb4
Merge branch 'main' into sys.exit-select_lines
beeankha 22ef6e8
Merge branch 'conda:main' into sys.exit-select_lines
beeankha 9d740b3
Revert 'cleanup' code changes from #5255
beeankha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was that basically an implicit dependency? Do we require it now in meta.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that it doesn't say "ruamel.yaml" but that package is certainly a regular dependency now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was previously an optional dependency but is currently listed as a requirement in
meta.yml
.This particular code change is more "cleanup" vs "remove
sys.exit
" (per work originally done in this PR), so I will revert this change; once the broken-out parts of the "removesys.exit
calls" work are merged, the original PR will get rebased and will mostly focus on cleanup.