-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use copy(v) which works also on str, instead of v.copy() which doesn't #5417
base: main
Are you sure you want to change the base?
Conversation
…oesn't resolves conda#5416 resolves conda#3404 (closed because stale, not because fixed) Bug was possibly introduced in conda#3344
We require contributors to sign our Contributor License Agreement and we don't have one on file for @corneliusroemer. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#965), and ping the bot to refresh the PR. |
CodSpeed Performance ReportMerging #5417 will not alter performanceComparing Summary
|
@conda-bot check |
Thanks for opening this. While we wait for the others to chime in, it would be really nice if you could add both a regression test for this and a news file entry. The regression test could go in The tricky part is finding the exact data to feed into the function to recreate the stacktrace, but I hope that you might be able to generate that seeing that you can recreate this issue yourself. Let us know if you need any help with that. |
Thanks @travishathaway! Happy to add news and try to get a test working - just wanted to check I'd not be wasting my time. |
Please add a test and news, and then we can merge. This PR won't make a version of conda-build until next year. |
resolves #5416
resolves #3404 (closed because stale, not because fixed)
Bug was possibly introduced in #3344
@msarahan @isuruf I think you are best acquainted with this part of the code base. I don't really know what's going on here - but this workaround fixes the bug for my use case.
Checklist - did you ...
Will fill out checklist if it's likely this will get merged
news
directory (using the template) for the next release's release notes?